Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: fixed Regular Expression Denial of Service vulnerability #2371

Merged
merged 1 commit into from Jan 9, 2021

Conversation

@staabm
Copy link
Member

@staabm staabm commented Jan 9, 2021

ReDoS, or Regular Expression Denial of Service, is a vulnerability affecting
poorly constructed and potentially inefficient regular expressions which can
make them perform extremely badly given a creatively constructed input string.

GHSL-2020-294

credits to @erik-krogh for reporting the issue and providing a fix

for details see GHSA-jxwx-85vp-gvwm

ReDoS, or Regular Expression Denial of Service, is a vulnerability affecting
poorly constructed and potentially inefficient regular expressions which can
make them perform extremely badly given a creatively constructed input string.

GHSL-2020-294

credits to @erik-krogh for reporting the issue and providing a fix
@staabm
Copy link
Member Author

@staabm staabm commented Jan 9, 2021

@pwntester I don't know what went wrong, but I opened the PR with the fix now manually, as the security advisory no longer allows me to access the private fork, so I could open a PR

@staabm staabm merged commit 5d8f29e into jquery-validation:master Jan 9, 2021
1 check passed
@staabm staabm deleted the re-dos branch Jan 9, 2021
@staabm
Copy link
Member Author

@staabm staabm commented Jan 9, 2021

@erik-krogh sorry for not giving proper credit via git commit autorship. I somehow fucked up the patching of the vulnerability.

the process using the gh security audit was not clear to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant