Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue 156 Fix for Ignore Not Working Properly #468

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

This patch makes the plugin actually ignore specified fields. Currently (as of jQuery 1.7.2 and Validation 1.9.0) a field specified to be ignored still runs through the validator and comes back as invalid.

Collaborator

jzaefferer commented Nov 23, 2012

Thanks for the contribution. Could you add a unit test for this?

Collaborator

jzaefferer commented Feb 27, 2013

Note: The element method is used in various places inside the plugin, like the valid plugin or the onxxx event handlers. Those don't check for ignored elements either, so it makes sense to do that inside the element method itself.

The implementation here is questionable. Might as well use the result of the validationTargetFor call to check for ignored elements.

Collaborator

jzaefferer commented Jan 14, 2014

This was supposed to get addressed by 3f464a8, but that change might be insufficient, since validationTargetFor only filters checkable elements with the ignore setting, not all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment