Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pull request for "Issue #473: Make cancel buttons a setting" #474

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Jelle-S commented Aug 8, 2012

This is a pull request for Issue #473: Make cancel buttons a setting

Jelle-S commented Nov 16, 2012

Can anyone have a look at this?

Collaborator

jzaefferer commented Nov 16, 2012

Soon(ish)!

In the meantime, could you add a unit test for this? Also rebase against master and linting (grunt lint) would help.

Collaborator

jzaefferer commented Nov 23, 2012

Rebase is not important, but unit test and linting would help a lot.

Collaborator

jzaefferer commented Feb 27, 2013

I don't want to add more options, there's too many already. With the next release, the cancel button can be configured with the formnovalidate attribute, see bcff73a
I'm planning to remove the .cancel class support, in favor of the html5 standard.

@jzaefferer jzaefferer closed this Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment