New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #317

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@scottgonzalez
Member

scottgonzalez commented Oct 22, 2016

This is a partial fix for #314. Specifically, this fixes the problem that prevents us from updating to the latest set of tests. However, I only went as far as the commit that caused the problems with the build system. Going further requires updating tests in order to avoid increasing test failures, so I want to address that part separately.

@jquerybot

This comment has been minimized.

Show comment
Hide comment
@jquerybot

jquerybot Oct 22, 2016

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

jquerybot commented Oct 22, 2016

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@@ -88,6 +88,9 @@ function getFiles(tree) {
function getTests(tree) {
return Promise.all(_.map(tree, function(object) {
if (object.type === 'tree') {

This comment has been minimized.

@scottgonzalez

scottgonzalez Oct 22, 2016

Member

The problem that we were encountering was the introduction of the resources directory inside the pointerevents directory. Since fs.outputFileAsync() automatically creates directories as necessary, we can just ignore all directories inside pointerevents.

@scottgonzalez

scottgonzalez Oct 22, 2016

Member

The problem that we were encountering was the introduction of the resources directory inside the pointerevents directory. Since fs.outputFileAsync() automatically creates directories as necessary, we can just ignore all directories inside pointerevents.

@bethge

The pointerevent_constructor test broke for me. That is the increasing test failures you mentioned, right?

Show outdated Hide outdated tests/support/pretest.js
@@ -88,6 +88,9 @@ function getFiles(tree) {
function getTests(tree) {
return Promise.all(_.map(tree, function(object) {
if (object.type === 'tree') {
return Promise.resolve()

This comment has been minimized.

@bethge

bethge Oct 26, 2016

Member

The linter would like to have a ;.

@bethge

bethge Oct 26, 2016

Member

The linter would like to have a ;.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Oct 26, 2016

Member

The pointerevent_constructor test broke for me. That is the increasing test failures you mentioned, right?

No, going past this point introduces a lot of failures, so I stopped here to prevent the big increase.

Member

scottgonzalez commented Oct 26, 2016

The pointerevent_constructor test broke for me. That is the increasing test failures you mentioned, right?

No, going past this point introduces a lot of failures, so I stopped here to prevent the big increase.

@bethge

This comment has been minimized.

Show comment
Hide comment
@bethge

bethge Oct 26, 2016

Member

Ah sorry, the test breaks due to 6ca690f . I guess once the w3c tests are up-to-date it will pass.

Something is up with your CLA, not sure if that is relevant.

Member

bethge commented Oct 26, 2016

Ah sorry, the test breaks due to 6ca690f . I guess once the w3c tests are up-to-date it will pass.

Something is up with your CLA, not sure if that is relevant.

@bethge

bethge approved these changes Oct 26, 2016

@scottgonzalez scottgonzalez deleted the scottgonzalez:update-tests branch Oct 26, 2016

@jquerybot jquerybot added the CLA: Error label Dec 8, 2016

@scottgonzalez scottgonzalez added this to the 0.4.3 milestone May 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment