Made == to === #854

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants
@vihanb
Contributor

vihanb commented Dec 27, 2015

Made all the == into === in Types.html because === is almost always better and promotes better practice.

@jquerybot

This comment has been minimized.

Show comment
Hide comment
@jquerybot

jquerybot Dec 27, 2015

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
Member

AurelioDeRosa commented Dec 28, 2015

LGTM

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Dec 28, 2015

Member

LGTM too, just need the CLA to be signed.

Member

dmethvin commented Dec 28, 2015

LGTM too, just need the CLA to be signed.

@vihanb

This comment has been minimized.

Show comment
Hide comment
@vihanb

vihanb Dec 29, 2015

Contributor

I've signed the CLA, and updated my Github name to match, is there anything else I need to do to make it update?

Contributor

vihanb commented Dec 29, 2015

I've signed the CLA, and updated my Github name to match, is there anything else I need to do to make it update?

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
@AurelioDeRosa

AurelioDeRosa Dec 29, 2015

Member

@dmethvin I think the reason why the label isn't updated is because there are still issues. Is that correct?

Member

AurelioDeRosa commented Dec 29, 2015

@dmethvin I think the reason why the label isn't updated is because there are still issues. Is that correct?

@arthurvr

This comment has been minimized.

Show comment
Hide comment
@arthurvr

arthurvr Dec 29, 2015

Member

The author of the git commit doesn't contain your last name, I think that's the problem. There are instructions here on how to fix it, just don't forget to fix the first commit too.

Member

arthurvr commented Dec 29, 2015

The author of the git commit doesn't contain your last name, I think that's the problem. There are instructions here on how to fix it, just don't forget to fix the first commit too.

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
@AurelioDeRosa

AurelioDeRosa Jan 16, 2016

Member

Hi @vihanb. Would you mind fixing your commit so that I can merge this PR?

Member

AurelioDeRosa commented Jan 16, 2016

Hi @vihanb. Would you mind fixing your commit so that I can merge this PR?

@vihanb

This comment has been minimized.

Show comment
Hide comment
@vihanb

vihanb Jan 16, 2016

Contributor

So the first commit is the one that doesn't seem to be updating the name. I've tried running git rebase -i and all that stuff but that didn't seem to fix it

Contributor

vihanb commented Jan 16, 2016

So the first commit is the one that doesn't seem to be updating the name. I've tried running git rebase -i and all that stuff but that didn't seem to fix it

Vihan Bhargava added some commits Jan 16, 2016

Vihan Bhargava
Clarified on where to put parenthesis
Specified parenthesis should be put around the numbers to avoid confusion for beginners
Vihan Bhargava

@jquerybot jquerybot added CLA: Valid and removed CLA: Error labels Jan 16, 2016

@vihanb

This comment has been minimized.

Show comment
Hide comment
@vihanb

vihanb Jan 16, 2016

Contributor

Oh okay, I've got it fixed

Contributor

vihanb commented Jan 16, 2016

Oh okay, I've got it fixed

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
@AurelioDeRosa

AurelioDeRosa Jan 16, 2016

Member

Great, thank you.

Member

AurelioDeRosa commented Jan 16, 2016

Great, thank you.

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
@AurelioDeRosa

AurelioDeRosa Jan 16, 2016

Member

@jquery/content I need a small advice here. The user has created two commits with unrelated changes but both of them are good to merge. Should I ask the user to create a new PR out of the second commit? THe problem is that for the second I cannot use the usual Closes gh-XXX format.

Member

AurelioDeRosa commented Jan 16, 2016

@jquery/content I need a small advice here. The user has created two commits with unrelated changes but both of them are good to merge. Should I ask the user to create a new PR out of the second commit? THe problem is that for the second I cannot use the usual Closes gh-XXX format.

@kswedberg

This comment has been minimized.

Show comment
Hide comment
@kswedberg

kswedberg Jan 16, 2016

Member

@AurelioDeRosa, If both commits look good, I think you should go ahead and merge them. After you push the changes, you can go to the issue covered by the second commit and manually post a comment saying "Closed by [SHA]." (replacing [SHA] with the actual commit sha). Sound reasonable?

Member

kswedberg commented Jan 16, 2016

@AurelioDeRosa, If both commits look good, I think you should go ahead and merge them. After you push the changes, you can go to the issue covered by the second commit and manually post a comment saying "Closed by [SHA]." (replacing [SHA] with the actual commit sha). Sound reasonable?

@AurelioDeRosa

This comment has been minimized.

Show comment
Hide comment
@AurelioDeRosa

AurelioDeRosa Jan 16, 2016

Member

Unfortunately we don't have an issue open for that either. However, I can easily open one.

Member

AurelioDeRosa commented Jan 16, 2016

Unfortunately we don't have an issue open for that either. However, I can easily open one.

@kswedberg

This comment has been minimized.

Show comment
Hide comment
@kswedberg

kswedberg Jan 16, 2016

Member

Ah, I see. Yeah, open an issue, please. And thank you!

Member

kswedberg commented Jan 16, 2016

Ah, I see. Yeah, open an issue, please. And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment