Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Framework: Updated section about overlay and shadow #245

Closed
wants to merge 1 commit into from

Conversation

jaspermdegroot
Copy link
Member

Updated the section about overlay and shadow on the CSS Framework page. See PR jquery/jquery-ui#1436

@@ -111,9 +111,9 @@
<h4>Overlay &amp; Shadow</h4>
<ul>
<li>
<code>.ui-widget-overlay</code>: Applies 100% width &amp; height dimensions to an overlay screen, along with background color/texture, and screen opacity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that still theme dependent? If you pick or create a theme with an overlay texture, you still get a texture. Assuming we're putting those variables back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All themes that are used with UI 1.12 use the new default theme.css as template. So the changes in overlay and shadow apply to all themes.

@jzaefferer
Copy link
Member

Nice, probably would've forgotten about this page, again.

@scottgonzalez
Copy link
Member

@jaspermdegroot @jzaefferer What's the status of this?

@jaspermdegroot
Copy link
Member Author

It turned out that the placeholders in the ui-widget-overlay rule were still needed (jquery/jquery-ui@d58051b) so it is still possible to have a background texture. I will commit an update and then I think this can be merged in the 1-12 branch.

@jaspermdegroot
Copy link
Member Author

@scottgonzalez @jzaefferer - Should be good to go now.

Note: When squashing the two commits "overlay" should be left out of the commit message because there won't be any overlay related changes after all.

@jzaefferer
Copy link
Member

Could you rebase or replace this PR to get rid of the unrelated commits?

@jaspermdegroot
Copy link
Member Author

@jzaefferer - Done.

@jzaefferer
Copy link
Member

Ah, that's all :-) Looks good.

jaspermdegroot added a commit that referenced this pull request Mar 9, 2015
@scottgonzalez scottgonzalez deleted the css-framework-update branch March 9, 2015 18:48
jaspermdegroot added a commit that referenced this pull request Mar 27, 2015
jaspermdegroot added a commit that referenced this pull request Apr 20, 2015
jaspermdegroot added a commit that referenced this pull request Apr 22, 2015
jaspermdegroot added a commit that referenced this pull request May 7, 2015
jaspermdegroot added a commit that referenced this pull request Sep 30, 2015
jaspermdegroot added a commit that referenced this pull request Oct 28, 2015
jaspermdegroot added a commit that referenced this pull request Oct 29, 2015
jaspermdegroot added a commit that referenced this pull request Dec 17, 2015
jzaefferer pushed a commit that referenced this pull request Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants