New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Framework: Updated section about overlay and shadow #245
Conversation
@@ -111,9 +111,9 @@ | |||
<h4>Overlay & Shadow</h4> | |||
<ul> | |||
<li> | |||
<code>.ui-widget-overlay</code>: Applies 100% width & height dimensions to an overlay screen, along with background color/texture, and screen opacity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that still theme dependent? If you pick or create a theme with an overlay texture, you still get a texture. Assuming we're putting those variables back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All themes that are used with UI 1.12 use the new default theme.css as template. So the changes in overlay and shadow apply to all themes.
Nice, probably would've forgotten about this page, again. |
@jaspermdegroot @jzaefferer What's the status of this? |
It turned out that the placeholders in the |
@scottgonzalez @jzaefferer - Should be good to go now. Note: When squashing the two commits "overlay" should be left out of the commit message because there won't be any overlay related changes after all. |
Could you rebase or replace this PR to get rid of the unrelated commits? |
67b8bad
to
1fa1844
Compare
1fa1844
to
e9162ee
Compare
@jzaefferer - Done. |
Ah, that's all :-) Looks good. |
Updated the section about overlay and shadow on the CSS Framework page. See PR jquery/jquery-ui#1436