Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 feature: Update to ES6 identifier grammar #1089

Closed
mathiasbynens opened this issue Mar 4, 2015 · 5 comments
Closed

ES6 feature: Update to ES6 identifier grammar #1089

mathiasbynens opened this issue Mar 4, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Mar 4, 2015

Esprima currently implements ES5 identifier grammar. It would be nice to update to ES6.

In case it’s helpful — I just wrote a blog post that documents the differences between ES5 and ES6 identifiers, with examples: https://mathiasbynens.be/notes/javascript-identifiers-es6

@mathiasbynens mathiasbynens changed the title Update to ES6 identifier grammar ES6 feature: Update to ES6 identifier grammar Mar 4, 2015
@ikarienator
Copy link
Contributor

@ikarienator ikarienator commented Mar 4, 2015

@mathiasbynens
Copy link
Contributor Author

@mathiasbynens mathiasbynens commented Mar 6, 2015

@ikarienator Thanks for the heads up! Is this observable? If so, how?

E.g. how should the following code behave:

Function('var var;'); // grammar error → throws?
Function('var v\\u0061r;'); // early error → throws (before execution)?
@michaelficarra
Copy link
Contributor

@michaelficarra michaelficarra commented Mar 6, 2015

@mathiasbynens They should both throw. I can't think of any way someone would be able to distinguish an early error from a grammar error.

@mikesherov mikesherov mentioned this issue Mar 7, 2015
25 of 25 tasks complete
@ariya ariya self-assigned this Jul 8, 2015
@ariya ariya added this to the 2.5 milestone Jul 8, 2015
@ariya ariya added the es6 label Jul 8, 2015
@ariya
Copy link
Contributor

@ariya ariya commented Jul 11, 2015

Since this is quite a big topic, I'll spawn few new tickets which will tackle the individual issues separately.

@ariya
Copy link
Contributor

@ariya ariya commented Jul 28, 2015

This is now covered by all the most recent commits.

@ariya ariya closed this Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants