npm test fails on Windows #1730

Open
ariya opened this Issue Jan 17, 2017 · 2 comments

Projects

None yet

2 participants

@ariya
Contributor
ariya commented Jan 17, 2017

Steps to reproduce:

git clone https://github.com/jquery/esprima.git
npm install
npm test

Expected: no error, every step is successful.

Actual: failing to run tsfmt:

> esprima@4.0.0-dev code-style C:\Users\ariya\esprima
> tsfmt --verify src/*.ts && tsfmt --verify test/*.js

src/*.ts does not exist. process abort.
@ariya ariya self-assigned this Jan 17, 2017
@ariya
Contributor
ariya commented Jan 17, 2017

This was tested on Windows 10 with Node.js v7.3.0 and npm 3.10.10.

@demoneaux
Contributor

This is because Windows doesn't have support for globbing by default. This could be fixed if tsfmt accepts strings and globs it instead of depending on the shell for globbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment