Normalize regex testing when using the new ES6 regex flags. #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
LG |
|
|
||
| // Nullify regex value for ES6 regex flags | ||
| if (key === 'value' && o.hasOwnProperty('regex')) { | ||
| if ('uy'.indexOf(o.regex.flags) >= 0) { |
There was a problem hiding this comment.
- This will only work if there's a single flag or if the flags are exactly
uy, in that order. - Why have this line at all? Just omit any regexp values when the node has a
regexfield.
There was a problem hiding this comment.
I'm hesitant to completely ignore the regex object for everything else, since there is a value doing that. I agree on the limited scope of the check, I'll expand it to account for cases whenever u or y is present.
On an environment that already supports the new ES6 regex flags, the regex value won't be null. This causes the test to be mistakenly marked as a failure since the baseline has the null value. To workaround this, ensure that regex value is always null when using the new ES6 regex flags. Other comparisons will still happen to ensure that the regex is handled properly. Fixes jquery#1271.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an environment that already supports the new ES6 regex flags,
the regex value won't be null. This causes the test to be mistakenly
marked as a failure since the baseline has the null value.
To workaround this, ensure that regex value is always null when using
the new ES6 regex flags. Other comparisons will still happen to ensure
that the regex is handled properly.
Fixes #1271.