Simplify handling the marker for node location #1726

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@ariya
Contributor
ariya commented Jan 10, 2017

Marker, MetaNode, JSXMetaNode are all merged into just one structure

Fix #1717

@ariya ariya Simplify handling the marker for node location
Marker, MetaNode, JSXMetaNode are all merged into just one structure

Fix #1717
758e02f
@codecov-io

Current coverage is 100% (diff: 100%)

Merging #1726 into master will not change coverage

@@           master   #1726   diff @@
=====================================
  Files           1       1          
  Lines        3979    3981     +2   
  Methods         0       0          
  Messages        0       0          
  Branches      699     700     +1   
=====================================
+ Hits         3979    3981     +2   
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last update 6020314...758e02f

@mikesherov

Looks good. Just a stray nit.

- lineNumber: this.scanner.lineNumber,
- lineStart: 0
+ line: this.scanner.lineNumber,
+ column: 0,
@mikesherov
mikesherov Jan 10, 2017 Member

Stray comma?

@ariya
ariya Jan 11, 2017 Contributor

Oops, good catch. Thank you for the notice @mikesherov!

@mikesherov
mikesherov Jan 11, 2017 Member

Maybe there's a tslint rule for this?

@ariya ariya added a commit that closed this pull request Jan 11, 2017
@ariya ariya Simplify handling the marker for node location
Marker, MetaNode, JSXMetaNode are all merged into just one structure

Fix #1717
Closes gh-1726
4b0f65e
@ariya ariya closed this in 4b0f65e Jan 11, 2017
@ariya ariya deleted the ariya:location-marker branch Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment