New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the pure tokenizer a bit aggressive in recognizing regex literals. #1889

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ariya
Contributor

ariya commented Nov 23, 2017

At the same time, ensure that it can fall back if the regex literal
proved to be invalid.

Fix #1772
Fix #1873

Make the pure tokenizer a bit aggressive in recognizing regex literals.
At the same time, ensure that it can fall back if the regex literal
proved to be invalid.

Fix #1772
Fix #1873
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 23, 2017

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1889   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4049    4056    +7     
  Branches      717     717           
======================================
+ Hits         4049    4056    +7
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512ce40...9834b4c. Read the comment docs.

codecov-io commented Nov 23, 2017

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1889   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4049    4056    +7     
  Branches      717     717           
======================================
+ Hits         4049    4056    +7
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512ce40...9834b4c. Read the comment docs.

@ariya ariya closed this in df749a7 Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment