Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unexpected "Invalid left-hand side in for-in" error #1993

Closed
wants to merge 1 commit into from

Conversation

@JosephPecoraro
Copy link
Contributor

JosephPecoraro commented Sep 11, 2019

Fixes #1920
Fixes #1944

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Sep 11, 2019

CLA assistant check
All committers have signed the CLA.

@JosephPecoraro JosephPecoraro force-pushed the JosephPecoraro:fix/1920 branch from 2c73566 to b36b67f Sep 11, 2019
@JosephPecoraro

This comment has been minimized.

Copy link
Contributor Author

JosephPecoraro commented Sep 11, 2019

Recommitting with email address that has signed the CLA.

@JosephPecoraro

This comment has been minimized.

Copy link
Contributor Author

JosephPecoraro commented Sep 11, 2019

@ariya Small Esprima bug fix! Are you available to review?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1993   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4055    4061    +6     
  Branches      715     715           
======================================
+ Hits         4055    4061    +6
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e55171...b36b67f. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1993   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4055    4061    +6     
  Branches      715     715           
======================================
+ Hits         4055    4061    +6
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e55171...b36b67f. Read the comment docs.

@donnagf

This comment has been minimized.

Copy link

donnagf commented Sep 20, 2019

@JosephPecoraro The author haven't been online for 6 days now, and if you look at other PR he doesn't use to follow up PR's anymore. Also your PR from august 2018 haven't been followed up. Over 1 year ago :)

As I mentioned before, this repo is stall, but the author doesn't like to admit that. The ES2018 features are missing and delayed with more than a year now and ES2020 is the upcoming standard.

@ariya ariya closed this in a971d87 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.