Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unexpected ILLEGAL token with function literal in template strings #1994

Closed
wants to merge 1 commit into from

Conversation

@JosephPecoraro
Copy link
Contributor

commented Sep 11, 2019

Fixes #1991

@JosephPecoraro

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@ariya Small Esprima bug fix! Are you available to review?

@codecov-io

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #1994 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1994   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4055    4056    +1     
  Branches      715     715           
======================================
+ Hits         4055    4056    +1
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e55171...f796f67. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #1994 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1994   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           1       1           
  Lines        4055    4056    +1     
  Branches      715     715           
======================================
+ Hits         4055    4056    +1
Impacted Files Coverage Δ
dist/esprima.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e55171...f796f67. Read the comment docs.

@ariya
ariya approved these changes Sep 14, 2019
Copy link
Contributor

left a comment

LGTM. Thanks a lot @JosephPecoraro!

@ariya ariya closed this in 3f9dc14 Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.