New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor validation helpers into a single module #445
Conversation
Amend build. Functional tests failing...
The outcome of this change is:
The whole purpose of keeping each validation separately is being able to balance the weight, i.e., only including them when necessary. In other words, currently no unnecessary validation is loaded. After the change, it is. Having said that, I'm mostly concerned/interested in seem the delta difference in the runtime modules (#398). Because, they use even less validations, therefore the impact will be bigger. |
What do these numbers mean? |
The size of final modules. |
Specifically, how can I read the percentages? |
Delta sizes (comparing master with this PR) |
So the main module gets bigger, the others get smaller? Doing the comparison on top of the runtime changes seems reasonable. |
yeap |
I am closing all old (and stalled) PRs |
Fixes #362
I made the functional changes, but can get past jshint:dist. Apparently the build system isn't able to handle this module type.
onBuildWrite
is kinda complicated, so I'm hoping for some help to debug this. Once it actually builds, we should get some numbers from the compare_size task.I definitely like the raw reduction in LOCs, currently 291 additions and 456 deletions. Less dependencies and factory arguments is nice.