jQuery.migrateWarningsTrace property to enable console traces #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

silentroach commented Jan 16, 2013

It is very hard to find deprecated jQuery calls only by warnings.

console.trace() is great to find what was called and where.

Member

mikesherov commented Jan 16, 2013

👍

I agree. I had to go into the Migrate code to insert some additional tracing code in order to find what was causing my warning (in issue #11). It would be handy if this was just standard behavior in jQuery Migrate.

Owner

dmethvin commented Jan 16, 2013

Rather than adding another property, perhaps jQuery.migrateWarn="trace" would do it. It would need to fall back for browsers that don't support trace.

Owner

dmethvin commented Jan 16, 2013

oh nevermind, I was thinking of the old code that has migrateWarn.

Contributor

silentroach commented Jan 16, 2013

Seems like it is ok with patch. Will you merge? :)

Owner

dmethvin commented Jan 16, 2013

Yes, I will make a couple of small changes and land this. @silentroach can you sign our CLA at http://jquery.github.com/cla.html ? Thanks.

Contributor

silentroach commented Jan 16, 2013

Thank you.
CLA is signed.

dmethvin closed this in 1a89479 Jan 17, 2013

Owner

dmethvin commented Jan 17, 2013

@silentroach Thanks so much for pointing this out! I had totally forgotten about console.trace(). Since people who really need this tend to have trouble following even the simplest instructions I made it the default but it can be disabled by setting the property to false. The minified plugin still keeps quiet about warnings.

@dmethvin dmethvin added a commit that referenced this pull request Jan 19, 2013

@dmethvin dmethvin Update authors file, ref gh-10. 2b1ecdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment