Ajax: Warn and fill the jQXHR .success, .error, and .complete methods #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @markelog, @gibson042 and @gnarf to be potential reviewers |
| migrateWarn( msg ); | ||
| return value; | ||
| }, | ||
| set: function( newValue ) { |
There was a problem hiding this comment.
As coveragebot observed, this is not being checked. I'll add a test.
dmethvin
force-pushed
the
88-ajax-deprecations
branch
from
ed08f7f
to
9cca74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
This reintroduces a streamlined
migrateWarnPropsince we don't need to support a missing brokenObject.definePropertylike IE8. That also means it will issue the warning on property access rather than wait until the method call, but that won't matter in most cases. In the cases where it does matter, you probably want to know where the property was accessed.