New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Make release script create CDN directory if missing #271

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@Krinkle
Member

Krinkle commented Sep 26, 2017

Currently until the directory is manually created:

$ node build/release.js 3.0.1
Current version is 3.0.1-pre; generating release 3.0.1
(...)
Copying dist/jquery-migrate.js to CDN/jquery-migrate-3.0.1.js
Error: ENOENT: no such file or directory, open 'CDN/jquery-migrate-3.0.1.js'
    at Object.fs.openSync (fs.js:652:18)

@Krinkle Krinkle requested a review from mgol Sep 26, 2017

@dmethvin

I'm good with this, you could also change releaseFiles to exclude the releaseDir and compose them in makeReleaseCopies() but it's not critical.

@jquery jquery deleted a comment from aa533aa Nov 19, 2017

Build: Make release script create CDN directory if missing
```
$ node build/release.js 3.0.1
Current version is 3.0.1-pre; generating release 3.0.1
(...)
Copying dist/jquery-migrate.js to CDN/jquery-migrate-3.0.1.js
Error: ENOENT: no such file or directory, open 'CDN/jquery-migrate-3.0.1.js'
    at Object.fs.openSync (fs.js:652:18)
```

@Krinkle Krinkle merged commit 496bd87 into master Nov 28, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@Krinkle Krinkle deleted the release branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment