New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Warn and fill jQuery.isWindow #290

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dmethvin
Member

dmethvin commented Feb 18, 2018

Fixes #263

warnings.md Outdated
@@ -206,6 +206,11 @@ See jQuery-ui [commit](https://github.com/jquery/jquery-ui/commit/c0093b599fcd58
**Solution:** Rewrite the page so that it does not require all jQuery ready handlers to be delayed. This might be accomplished, for example, by late-loading only the code that requires the delay when it is safe to run. Due to the complexity of this method, jQuery Migrate does not attempt to fill the functionality. If the underlying version of jQuery used with jQuery Migrate no longer contains `jQuery.holdReady()` the code will fail shortly after this warning appears.
### JQMIGRATE: jQuery.isWindow() is deprecated
**Cause:** This method returns `true` if its argument is thought to be a `window` element. It was created for internal use but is no longer used by jQuery.

This comment has been minimized.

@mgol

mgol Feb 19, 2018

Member

We still use the helper function internally, just not jQuery.isWindow directly so while technically this is true it looks like we no longer needed the utility and we removed it when in fact we've just hidden it from the public API. This was done in a larger effort of removing utility functions that we think are better either written by hand or taken from another library as we don't position jQuery as a bag of library functions.

I'd remove the last sentence from this paragraph; we could replace it with something else but I don't have very good ideas.

@dmethvin

This comment has been minimized.

Member

dmethvin commented Mar 8, 2018

This needs to have coded added that checks for 3.3.0 or higher, since previous versions used .isWindow() internally.

@dmethvin

This comment has been minimized.

Member

dmethvin commented Apr 12, 2018

Made requested changes and added the version check.

@dmethvin dmethvin closed this in bf48bce Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment