Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Build: Allow to pass browserSets & jQuery version to testswarm task #59

Merged
merged 1 commit into from Jun 9, 2014

Conversation

Projects
None yet
2 participants
Member

mgol commented Feb 5, 2014

Migrate should be tested against oldIE, hence the popular browser set. Also, we've started testing against the ios browser set (currently iOS6 only), Migrate should be tested against it as well.

@dmethvin Why was the popular-no-old-ie browser set set here?

Owner

dmethvin commented Feb 5, 2014

Well, it's complicated. The current test runs through this list of file combos to make sure Migrate's dev version (which has console output) and min version (which doesn't) work properly with jQuery core versions back to 1.6.4. Since some of those are 2.x versions they can't run on oldIE.

What we really need are two separate jobs to handle the 1.x and 2.x core branches, with different browser sets. I had planned to do that but didn't get around to it!

@mgol mgol self-assigned this May 5, 2014

mgol added a commit to mgol/jquery-migrate that referenced this pull request May 5, 2014

Build: Allow to pass browserSets & jQuery version to testswarm task
So far, Migrate has been tested only on browsers supported by jQuery 2.x.
This commit changes the configuration so that different browserSets can
be tested with jQuery 2.x and 1.x.

Closes gh-59

@mgol mgol changed the title from Build: Run tests on "popular" and "ios" browser sets to Build: Allow to pass browserSets & jQuery version to testswarm task May 5, 2014

Member

mgol commented May 5, 2014

@dmethvin I updated the PR; now it auguments the testswarm task config instead. Once this is ready to merge, I'll need to clone the Migrate Jenkins job and adjust settings passed to the task. Then, older IE versions will be tested as well.

(BTW, should I add IE6-8 to the older set or just IE8?)

Owner

dmethvin commented May 20, 2014

So is this one ready to land?

Member

mgol commented May 20, 2014

Yes, I think so. I'll need to add a separate Jenkins job once it lands (just landing will actually decrease what's tested since only Core 2.x will be tested by default) so I'd like to do those things at the same time.

Can I land it?

mgol added a commit to mgol/jquery-migrate that referenced this pull request Jun 2, 2014

Build: Allow to pass browserSets & jQuery version to testswarm task
So far, Migrate has been tested only on browsers supported by jQuery 2.x.
This commit changes the configuration so that different browserSets can
be tested with jQuery 2.x and 1.x.

Closes gh-59
Owner

dmethvin commented Jun 9, 2014

go for it

@dmethvin dmethvin added this to the 1.3.0 milestone Jun 9, 2014

mgol added a commit to mgol/jquery-migrate that referenced this pull request Jun 9, 2014

Build: Allow to pass browserSets & jQuery version to testswarm task
So far, Migrate has been tested only on browsers supported by jQuery 2.x.
This commit changes the configuration so that different browserSets can
be tested with jQuery 2.x and 1.x.

Closes gh-59

@mgol mgol merged commit 6b43f8a into jquery:master Jun 9, 2014

@mgol mgol deleted the mgol:browserSets branch Jun 9, 2014

Member

mgol commented Jun 9, 2014

The first two jobs were generated:

  1. For 2.x: http://swarm.jquery.org/job/3130
  2. For 1.x: http://swarm.jquery.org/job/3131

Unfortunately, there is some problem with IE8, it's failing quickly, in testinit itself; see e.g: http://swarm.jquery.org/result/1901102. The message says:

'null' is null or not an object
in http://builds.jenkins.jquery.com/jquery-migrate/45b6bbf97ba902a5ea631928598f6db504270cc5/test/testinit.js on line 69
Member

mgol commented Jun 9, 2014

OK, no idea why it's reported this way. I run it on IE8 in BrowserStack and there are 3 errors; see screenshots:
screen shot 2014-06-09 at 21 06 30
screen shot 2014-06-09 at 21 06 39

Owner

dmethvin commented Jun 9, 2014

Well, the failure point gives a possible reason: 😸

https://github.com/jquery/jquery-migrate/blob/master/test/testinit.js#L66

I don't recall if QUnit every created an extension point to do what that needs done, which is to let us have select boxes in their toolbar.

Owner

dmethvin commented Jun 9, 2014

Seems like it should fail everywhere though, doesn't it? Maybe the testinit code is reached too early, but I dunno why that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment