Permalink
Browse files

Fix for issue #4424 - Transitions with Pages that have Fixed Toolbars…

… - Remove class in class after transition completes
  • Loading branch information...
arschmitz committed Oct 16, 2012
1 parent 7f27938 commit 00a2926280a5a1f0fbc662214fd58ec2a630e0b4
Showing with 4 additions and 1 deletion.
  1. +4 −1 js/widgets/fixedToolbar.js
@@ -204,7 +204,10 @@ define( [ "jquery", "../jquery.mobile.widget", "../jquery.mobile.core", "../jque
if ( this._useTransition( notransition ) ) {
$el
.removeClass( "out " + hideClass )
.addClass( "in" );
.addClass( "in" )
.animationComplete(function () {
$el.removeClass('in');
});
}
else {
$el.removeClass( hideClass );

2 comments on commit 00a2926

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Oct 17, 2012

Contributor

This one appears to be breaking our fixed-toolbar test. Most likely the test just needs to be updated:

http://swarm.jquery.org:8080/job/jQuery%20Mobile%20Phantom%20Master/775/console

Contributor

johnbender replied Oct 17, 2012

This one appears to be breaking our fixed-toolbar test. Most likely the test just needs to be updated:

http://swarm.jquery.org:8080/job/jQuery%20Mobile%20Phantom%20Master/775/console

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Oct 18, 2012

Member

The test that's failing explicitly looks for the in class after show which this commit removes. I'm not sure if this class should be there for something else after the animation completes but it dosent seem as though it should. It should only be there durring transition. otherwise this test and the 4th test in this set also which tests for the same thing should be removed. With these tests removed everything runs fine (of course lol)

Member

arschmitz replied Oct 18, 2012

The test that's failing explicitly looks for the in class after show which this commit removes. I'm not sure if this class should be there for something else after the animation completes but it dosent seem as though it should. It should only be there durring transition. otherwise this test and the 4th test in this set also which tests for the same thing should be removed. With these tests removed everything runs fine (of course lol)

Please sign in to comment.