Permalink
Browse files

Fix for issue 2451:

����Dialog not working if $.mobile.ajaxEnabled = false����
#2451

related/dup bug 2202:

����Dialog loads in new page with ajaxEnabled = false����
#2202

- Modified the default click handler to check if the href is for an embedded page before bailing when ajaxEnabled = false. This allows us to navigate to internal/embedded pages/dialogs on the click versus waiting for the accidental hashchange that was the result of the browser's default handling of hash fragments.
  • Loading branch information...
1 parent 2d3cbbe commit 0fbea8f8e6b5127f820d8758bcb78edc7351b283 @jblas jblas committed Sep 19, 2011
Showing with 6 additions and 6 deletions.
  1. +6 −6 js/jquery.mobile.navigation.js
@@ -1215,18 +1215,18 @@
return false;
}
+ var baseUrl = getClosestBaseUrl( $link ),
+
+ //get href, if defined, otherwise default to empty hash
+ href = path.makeUrlAbsolute( $link.attr( "href" ) || "#", baseUrl );
+
//if ajax is disabled, exit early
- if( !$.mobile.ajaxEnabled ){
+ if( !$.mobile.ajaxEnabled && !path.isEmbeddedPage( href ) ){
httpCleanup();
//use default click handling
return;
}
- var baseUrl = getClosestBaseUrl( $link ),
-
- //get href, if defined, otherwise default to empty hash
- href = path.makeUrlAbsolute( $link.attr( "href" ) || "#", baseUrl );
-
// XXX_jblas: Ideally links to application pages should be specified as
// an url to the application document with a hash that is either
// the site relative path or id to the page. But some of the

0 comments on commit 0fbea8f

Please sign in to comment.