Skip to content
This repository
Browse code

default for loadPage should be to not show the loading message, since…

… its default use case is to fetch a page that is not yet active. However, changePage should cause it to show because loadPage is being called during a page change.
  • Loading branch information...
commit 1a828594f5b667c82f8834db6f62ce9c9aff31fd 1 parent f70a947
authored July 21, 2011

Showing 1 changed file with 3 additions and 2 deletions. Show diff stats Hide diff stats

  1. 5  js/jquery.mobile.navigation.js
5  js/jquery.mobile.navigation.js
@@ -742,7 +742,7 @@
742 742
 		data: undefined,
743 743
 		reloadPage: false,
744 744
 		role: undefined, // By default we rely on the role defined by the @data-role attribute.
745  
-		showLoadMsg: true,
  745
+		showLoadMsg: false,
746 746
 		pageContainer: undefined
747 747
 	};
748 748
 
@@ -942,7 +942,8 @@
942 942
 		fromHashChange: false,
943 943
 		role: undefined, // By default we rely on the role defined by the @data-role attribute.
944 944
 		duplicateCachedPage: undefined,
945  
-		pageContainer: undefined
  945
+		pageContainer: undefined,
  946
+		showLoadMsg: true //loading message shows by default when pages are being fetched during changePage
946 947
 	};
947 948
 
948 949
 /* Event Bindings - hashchange, submit, and click */

2 notes on commit 1a82859

Nicholas Kinsey

do not want

Scott Jehl

Any reason in particular? It seemed intrusive/annoying to us that prefetching pages in the background would cause the loader to appear. It still shows up during page changes of course.

Please sign in to comment.
Something went wrong with that request. Please try again.