Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

default for loadPage should be to not show the loading message, since…

… its default use case is to fetch a page that is not yet active. However, changePage should cause it to show because loadPage is being called during a page change.
  • Loading branch information...
commit 1a828594f5b667c82f8834db6f62ce9c9aff31fd 1 parent f70a947
scottjehl authored
Showing with 3 additions and 2 deletions.
  1. +3 −2 js/jquery.mobile.navigation.js
View
5 js/jquery.mobile.navigation.js
@@ -742,7 +742,7 @@
data: undefined,
reloadPage: false,
role: undefined, // By default we rely on the role defined by the @data-role attribute.
- showLoadMsg: true,
+ showLoadMsg: false,
pageContainer: undefined
};
@@ -942,7 +942,8 @@
fromHashChange: false,
role: undefined, // By default we rely on the role defined by the @data-role attribute.
duplicateCachedPage: undefined,
- pageContainer: undefined
+ pageContainer: undefined,
+ showLoadMsg: true //loading message shows by default when pages are being fetched during changePage
};
/* Event Bindings - hashchange, submit, and click */

2 comments on commit 1a82859

@pyrotechnick

do not want

@scottjehl

Any reason in particular? It seemed intrusive/annoying to us that prefetching pages in the background would cause the loader to appear. It still shows up during page changes of course.

Please sign in to comment.
Something went wrong with that request. Please try again.