Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix to #3351, dialogs reopening when attempting to close them

  • Loading branch information...
commit 240505a4338ae8c94e7c3e1e730bc5220060c4b1 1 parent 956075c
Josh Dean authored
Showing with 4 additions and 1 deletion.
  1. +4 −1 js/jquery.mobile.dialog.js
5 js/jquery.mobile.dialog.js
View
@@ -39,7 +39,10 @@ $.widget( "mobile.dialog", $.mobile.widget, {
// this must be an anonymous function so that select menu dialogs can replace
// the close method. This is a change from previously just defining data-rel=back
// on the button and letting nav handle it
- headerCloseButton.bind( "vclick", function() {
+ //
+ // Use click rather than vclick in order to prevent the possibility of unintentionally
+ // reopening the dialog if the dialog opening item was directly under the close button.
+ headerCloseButton.bind( "click", function() {
self.close();
});
Please sign in to comment.
Something went wrong with that request. Please try again.