Skip to content
This repository
Browse code

Fix to #3351, dialogs reopening when attempting to close them

  • Loading branch information...
commit 240505a4338ae8c94e7c3e1e730bc5220060c4b1 1 parent 956075c
authored

Showing 1 changed file with 4 additions and 1 deletion. Show diff stats Hide diff stats

  1. 5  js/jquery.mobile.dialog.js
5  js/jquery.mobile.dialog.js
@@ -39,7 +39,10 @@ $.widget( "mobile.dialog", $.mobile.widget, {
39 39
 		// this must be an anonymous function so that select menu dialogs can replace
40 40
 		// the close method. This is a change from previously just defining data-rel=back
41 41
 		// on the button and letting nav handle it
42  
-		headerCloseButton.bind( "vclick", function() {
  42
+		//
  43
+		// Use click rather than vclick in order to prevent the possibility of unintentionally
  44
+		// reopening the dialog if the dialog opening item was directly under the close button.
  45
+		headerCloseButton.bind( "click", function() {
43 46
 			self.close();
44 47
 		});
45 48
 

0 notes on commit 240505a

Please sign in to comment.
Something went wrong with that request. Please try again.