This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Merge pull request #2812 from redaemn/flip-switch-improvements
Fix for issue #2756 - flip toggle slider animated snapping. Thanks redaemn!
- Loading branch information
Showing
3 changed files
with
170 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6264d95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toddparker
I'm a tad wary of making a big code change like this, especially given the low priority of the ticket it addresses. As an aside this also broke the build :(
6264d95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnbender
mmhh... it's strange... I ran the slider unit test file on its own and it worked; I didn't notice that running all the test suite caused a problem. I'll look into it.
6264d95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redaemn
I just made a commit to correct the issue. In firefox the
.css
calls were returning pixel values so that required some juggling.6264d95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnbender
OK! But I still don't understand why I ran the slider unit test file (
/tests/unit/slider
) on Chrome and it worked; when I ran it as part of the test suite (/tests/unit
) it didn't. Any suggestion?