Permalink
Browse files

[popup] Removing stack unwind introduced in 8416315 to prevent blue f…

…lash on Android, since the real reason for the blue flash may have been the triggering of the focus-capture code induced by a superfluous mouseup that results in a focusin on an element beneath the popup.
  • Loading branch information...
1 parent 555e07a commit 70dc4c8cf8ac8a56590b4ea303bfd968fec38cad @gabrielschulhof gabrielschulhof committed Nov 20, 2012
Showing with 3 additions and 11 deletions.
  1. +3 −11 js/widgets/popup.js
View
14 js/widgets/popup.js
@@ -523,21 +523,13 @@ define( [ "jquery",
return { x: x, y: y };
},
- _completeOpen: function() {
- this._ui.container.attr( "tabindex", "0" ).focus();
- this._expectResizeEvent();
- this._trigger( "afteropen" );
- },
-
_openPrereqsComplete: function() {
this._ui.container.addClass( "ui-popup-active" );
this._isOpen = true;
this._resizeScreen();
-
- // Android appears to trigger the animation complete before the popup
- // is visible. Allowing the stack to unwind before applying focus prevents
- // the "blue flash" of element focus in android 4.0
- setTimeout( $.proxy( this, "_completeOpen" ) );
+ this._ui.container.attr( "tabindex", "0" ).focus();
+ this._expectResizeEvent();
+ this._trigger( "afteropen" );
},
_open: function( options ) {

0 comments on commit 70dc4c8

Please sign in to comment.