Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixes #2553 — Addresses issue where underlying checkboxes/radio butto…

…ns were not being updated when enhanced buttons were clicked.
  • Loading branch information...
commit 8da75eb6b5de0d283e2061347f2575c240d32fce 1 parent 7e7b1b6
@Wilto Wilto authored
Showing with 9 additions and 11 deletions.
  1. +9 −11 js/jquery.mobile.forms.checkboxradio.js
View
20 js/jquery.mobile.forms.checkboxradio.js
@@ -74,8 +74,8 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
}
self._cacheVals();
-
- input.prop( "checked", inputtype === "radio" && true || !input.prop( "checked" ) );
+ input.attr( "checked", inputtype === "radio" && true || !input.attr( "checked" ) );
+ //input.prop( "checked", inputtype === "radio" && true || !input.attr( "checked" ) );
// trigger click handler's bound directly to the input as a substitute for
// how label clicks behave normally in the browsers
@@ -87,7 +87,7 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
// Input set for common radio buttons will contain all the radio
// buttons, but will not for checkboxes. clearing the checked status
// of other radios ensures the active button state is applied properly
- self._getInputSet().not( input ).prop( "checked", false );
+ self._getInputSet().not( input ).removeAttr( "checked" );
self._updateAll();
return false;
@@ -107,11 +107,11 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
// Adds checked attribute to checked input when keyboard is used
if ( $this.is( ":checked" ) ) {
- $this.prop( "checked", true);
- self._getInputSet().not($this).prop( "checked", false );
+ $this.attr( "checked", "checked" );
+ self._getInputSet().not($this).removeAttr( "checked" );
} else {
- $this.prop( "checked", false );
+ $this.removeAttr( "checked" );
}
self._updateAll();
@@ -167,13 +167,11 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
// input[0].checked expando doesn't always report the proper value
// for checked='checked'
- if ( $( input[ 0 ] ).prop( "checked" ) ) {
-
+
+ if ( input[ 0 ].getAttribute( "checked" ) ) {
label.addClass( this.checkedClass ).removeClass( this.uncheckedClass );
icon.addClass( this.checkedicon ).removeClass( this.uncheckedicon );
-
} else {
-
label.removeClass( this.checkedClass ).addClass( this.uncheckedClass );
icon.removeClass( this.checkedicon ).addClass( this.uncheckedicon );
}
@@ -186,7 +184,7 @@ $.widget( "mobile.checkboxradio", $.mobile.widget, {
},
disable: function() {
- this.element.prop( "disabled", true ).parent().addClass( "ui-disabled" );
+ this.element.attr( "disabled", true ).parent().addClass( "ui-disabled" );
},
enable: function() {
Please sign in to comment.
Something went wrong with that request. Please try again.