Skip to content
This repository
Browse code

use just the hash as a selector in ie7 Fixes #4917

  • Loading branch information...
commit cfdc782b3d6e3600f60392adbf87f8f3c4ddefa2 1 parent 17eb661
John Bender authored August 30, 2012

Showing 1 changed file with 4 additions and 2 deletions. Show diff stats Hide diff stats

  1. 6  js/widgets/popup.js
6  js/widgets/popup.js
@@ -552,7 +552,7 @@ define( [ "jquery",
552 552
 
553 553
 			if ( this.options.overlayTheme && androidBlacklist ) {
554 554
 				/* TODO:
555  
-				The native browser on Android 4.0.X ("Ice Cream Sandwich") suffers from an issue where the popup overlay appears to be z-indexed 
  555
+				The native browser on Android 4.0.X ("Ice Cream Sandwich") suffers from an issue where the popup overlay appears to be z-indexed
556 556
 				above the popup itself when certain other styles exist on the same page -- namely, any element set to `position: fixed` and certain
557 557
 				types of input. These issues are reminiscent of previously uncovered bugs in older versions of Android’s native browser:
558 558
 				https://github.com/scottjehl/Device-Bugs/issues/3
@@ -746,7 +746,9 @@ define( [ "jquery",
746 746
 	$.mobile.popup.handleLink = function( $link ) {
747 747
 		var closestPage = $link.closest( ":jqmData(role='page')" ),
748 748
 			scope = ( ( closestPage.length === 0 ) ? $( "body" ) : closestPage ),
749  
-			popup = $( $link.attr( "href" ), scope[0] ),
  749
+			// NOTE make sure to get only the hash, ie7 (wp7) return the absolute href
  750
+			//      in this case ruining the element selection
  751
+			popup = $( $.mobile.path.parseUrl($link.attr( "href" )).hash, scope[0] ),
750 752
 			offset;
751 753
 
752 754
 		if ( popup.data( "popup" ) ) {

0 notes on commit cfdc782

Please sign in to comment.
Something went wrong with that request. Please try again.