Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Tightened up vertical spacing for form field containers at smartphone…

… widths

There was more spacing between elements than needed, this cleans it up.
  • Loading branch information...
commit e476ea615f421b0acba3086545433ffe48ee55bc 1 parent 055e15e
@toddparker toddparker authored
View
4 css/structure/jquery.mobile.controlgroup.css
@@ -1,6 +1,6 @@
-.ui-controlgroup, fieldset.ui-controlgroup { padding: 0; margin: .5em 0 1em; }
+.ui-controlgroup, fieldset.ui-controlgroup { padding: 0; margin: 0em 0 .5em; }
.ui-bar .ui-controlgroup { margin: 0 .3em; }
-.ui-controlgroup-label { font-size: 16px; line-height: 1.4; font-weight: normal; margin: 0 0 .3em; }
+.ui-controlgroup-label { font-size: 16px; line-height: 1.4; font-weight: normal; margin: 0 0 .4em 0; }

@toddparker - Just curious why you added the last "0" there. Isn't it unnecessary since the second value is also "0"? Readability?

That was mainly because I was fiddling with margins on all sides earlier and that ended up being left in. We could go back to the shorthand notation.

Done - #3318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
.ui-controlgroup-controls { display: block; width: 100%;}
.ui-controlgroup li { list-style: none; }
.ui-controlgroup-vertical .ui-btn,
View
2  css/structure/jquery.mobile.forms.fieldcontain.css
@@ -1,4 +1,4 @@
-.ui-field-contain, fieldset.ui-field-contain { padding: 1.5em 0; margin: 0; border-width: 0 0 1px 0; overflow: visible; }
+.ui-field-contain, fieldset.ui-field-contain { padding: .8em 0; margin: 0; border-width: 0 0 1px 0; overflow: visible; }
.ui-field-contain:first-child { border-top-width: 0; }
@media all and (min-width: 450px){
.ui-field-contain, .ui-mobile fieldset.ui-field-contain { border-width: 0; padding: 0; margin: 1em 0; }
@jakeboone02

@toddparker - Just curious why you added the last "0" there. Isn't it unnecessary since the second value is also "0"? Readability?

@toddparker

That was mainly because I was fiddling with margins on all sides earlier and that ended up being left in. We could go back to the shorthand notation.

Please sign in to comment.
Something went wrong with that request. Please try again.