New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar link stays active when using changePage() #1181

Closed
dirkpennings opened this Issue Mar 3, 2011 · 5 comments

Comments

Projects
None yet
7 participants
@dirkpennings

dirkpennings commented Mar 3, 2011

When using $.mobile.changePage() to navigate to your second internal linked page and going back through the back button, you see the clicked navbar link still has the class "ui-btn-active".

This unlike the normal internal linking functionality..

examples (click the "Bar" menu option):

normal, working: http://jsfiddle.net/dirkpennings/kt7VQ/

changePage, not working: http://jsfiddle.net/dirkpennings/EPUqj/

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 22, 2011

Contributor

Updated the changePage example with latest:
http://jsfiddle.net/EPUqj/4/

Contributor

toddparker commented Sep 22, 2011

Updated the changePage example with latest:
http://jsfiddle.net/EPUqj/4/

@ghost ghost assigned johnbender Sep 22, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Feb 15, 2012

Contributor

@dirkpennings - Is this still an issue with 1.0.1?
Also please test on master (1.1-pre): www.jquerymobile.com/test

Contributor

toddparker commented Feb 15, 2012

@dirkpennings - Is this still an issue with 1.0.1?
Also please test on master (1.1-pre): www.jquerymobile.com/test

@jefftougas

This comment has been minimized.

Show comment
Hide comment
@jefftougas

jefftougas Feb 29, 2012

Still seems to be an issue.. Example with nightly build: http://jsfiddle.net/YkhQH/2/

jefftougas commented Feb 29, 2012

Still seems to be an issue.. Example with nightly build: http://jsfiddle.net/YkhQH/2/

@ghost ghost assigned jasondscott Jun 8, 2012

jasondscott pushed a commit to jasondscott/jquery-mobile that referenced this issue Jun 21, 2012

Jason Scott
Fixes: #1181 - navbar link stays active when using changePage()
Clears the active button class on the pressed navbar button after a
pagechange.
@polarfish

This comment has been minimized.

Show comment
Hide comment
@polarfish

polarfish Feb 4, 2013

Excuse me, I may not completely understand the process of releasing fixes, but when the fix of this bug will be released? In version 1.3.0? It's opened 2 years ago and still has "No milestone" label.

polarfish commented Feb 4, 2013

Excuse me, I may not completely understand the process of releasing fixes, but when the fix of this bug will be released? In version 1.3.0? It's opened 2 years ago and still has "No milestone" label.

jaspermdegroot added a commit that referenced this issue Feb 4, 2013

Merge pull request #4579 from jasondscott/1181_ActiveNavBtn
Fixes: #1181 - navbar link stays active when using changePage()
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 4, 2013

Member

Closing as fixed by 64143ae

Member

jaspermdegroot commented Feb 4, 2013

Closing as fixed by 64143ae

jaspermdegroot added a commit that referenced this issue Apr 1, 2013

Navbar: Changed active state logic. Fixes #5707
Removed workaround for #1181. Fixed that issue by addressing the actual cause: event.target returns ui-btn-inner instead of the anchor

jaspermdegroot added a commit that referenced this issue Apr 1, 2013

Navbar: Changed active state logic. Fixes #5707
Removed workaround for #1181. Fixed that issue by addressing the actual cause: event.target returns ui-btn-inner instead of the anchor

jaspermdegroot added a commit that referenced this issue Apr 1, 2013

Navbar: make sure nav buttons with href="#" still get active state.
This fixes a regression from the fix for #5707. That issue was a regression from the fix for #1181. I added the workaround for #1181 again but changed the event to avoid the regression.

jaspermdegroot added a commit that referenced this issue Apr 1, 2013

Navbar: make sure nav buttons with href="#" still get active state.
This fixes a regression from the fix for #5707. That issue was a regression from the fix for #1181. I added the workaround for #1181 again but changed the event to avoid the regression.

@jaspermdegroot jaspermdegroot referenced this issue May 13, 2014

Closed

Navbar Review #7359

0 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment