New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native checkboxes and radio buttons partially visible since A4 #1336

Closed
IgitBuh opened this Issue Apr 1, 2011 · 14 comments

Comments

Projects
None yet
6 participants
@IgitBuh

IgitBuh commented Apr 1, 2011

It seems that with A4 a visual flaw came up for checkboxes and radio buttons that are now partially visible behind the actual overlayed control elements. I'm quite sure it doesn't affect all platforms, but at least it does affect Firefox 4.0.

Please compare A3 in Firefox 4.0 (where everything looks fine):
http://jquerymobile.com/demos/1.0a3/#docs/forms/forms-all.html

to A4 (where the checkboxes at "Font styling" and radio buttons at "Layout view" are visible):
http://jquerymobile.com/demos/1.0a4/#docs/forms/forms-all.html

If you for some reason can't reproduce the problem, please let me know. I'll provide a screenshot to show what I mean.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 1, 2011

Contributor

This is this desktop Firefox 4, right?

Contributor

toddparker commented Apr 1, 2011

This is this desktop Firefox 4, right?

@IgitBuh

This comment has been minimized.

Show comment
Hide comment
@IgitBuh

IgitBuh Apr 1, 2011

Yes, the ordinary desktop version.
I know, it's jQuery mobile, but I guess the goal is to support dektop browsers as well.
This issue isn't present in bada (1.2) nor in Opera Mini. Haven't tested with other platforms, yet.

IgitBuh commented Apr 1, 2011

Yes, the ordinary desktop version.
I know, it's jQuery mobile, but I guess the goal is to support dektop browsers as well.
This issue isn't present in bada (1.2) nor in Opera Mini. Haven't tested with other platforms, yet.

@IgitBuh IgitBuh closed this Apr 1, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 1, 2011

Contributor

Sure, we'll take a look. Out of curiosity how does A4 look on Bada? We don't have a test device so that platform is a bit of a mystery.

Contributor

toddparker commented Apr 1, 2011

Sure, we'll take a look. Out of curiosity how does A4 look on Bada? We don't have a test device so that platform is a bit of a mystery.

@IgitBuh

This comment has been minimized.

Show comment
Hide comment
@IgitBuh

IgitBuh Apr 1, 2011

Moved all comments about bada to #1353

IgitBuh commented Apr 1, 2011

Moved all comments about bada to #1353

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 1, 2011

Contributor

We welcome your help in flagging issues and proposing patches. Thanks. Would you mind creating an issue for #2 along with screenshots an, ideally, info on what code you think is tripping it up. #1 falls into area that we're re-factoring now and may still be slow if your device is underpowered. #3 may be a recent regression on many platforms.

Contributor

toddparker commented Apr 1, 2011

We welcome your help in flagging issues and proposing patches. Thanks. Would you mind creating an issue for #2 along with screenshots an, ideally, info on what code you think is tripping it up. #1 falls into area that we're re-factoring now and may still be slow if your device is underpowered. #3 may be a recent regression on many platforms.

@toddparker toddparker reopened this Apr 2, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 2, 2011

Contributor

I just re-opened. People accidentally close issues all the time when they comment.

Contributor

toddparker commented Apr 2, 2011

I just re-opened. People accidentally close issues all the time when they comment.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 3, 2011

Contributor

IJay - Re: #3, I think we had a regression on the page scroll position in A4 so maybe that's the issue here - can you compare with A3 and comment in #1353? The overall smoothness and sequence of transitions is under heavy revision right now for beta so hopefully what you're seeing will improve then. We'll have you test it.

Could you do me a favor and make sure all the Bada info from your comment here is copied over to the new #1353 ticket, then delete your comments here to keep this ticket about FF.

Contributor

toddparker commented Apr 3, 2011

IJay - Re: #3, I think we had a regression on the page scroll position in A4 so maybe that's the issue here - can you compare with A3 and comment in #1353? The overall smoothness and sequence of transitions is under heavy revision right now for beta so hopefully what you're seeing will improve then. We'll have you test it.

Could you do me a favor and make sure all the Bada info from your comment here is copied over to the new #1353 ticket, then delete your comments here to keep this ticket about FF.

@marcoos

This comment has been minimized.

Show comment
Hide comment
@marcoos

marcoos May 11, 2011

Interesting, I was able to reproduce this bug in Firefox 4 on Windows at my workplace earlier today, but can't reproduce this in Firefox 4 on Mac at home now (neither on Firefox 4 nor Firefox Aurora). A Windows-only issue?

marcoos commented May 11, 2011

Interesting, I was able to reproduce this bug in Firefox 4 on Windows at my workplace earlier today, but can't reproduce this in Firefox 4 on Mac at home now (neither on Firefox 4 nor Firefox Aurora). A Windows-only issue?

@ghost ghost assigned gseguin Jul 21, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 22, 2011

Contributor

I just checked the radios and checks in FF 5/Mac and things look good so I'm closing as fixed.

Contributor

toddparker commented Sep 22, 2011

I just checked the radios and checks in FF 5/Mac and things look good so I'm closing as fixed.

@toddparker toddparker closed this Sep 22, 2011

@IgitBuh

This comment has been minimized.

Show comment
Hide comment
@IgitBuh

IgitBuh Sep 22, 2011

Uhm ... no?
Why do you close this one having checked on Mac only? As Marcoos wrote the problem doesn't seem to be present in FF on a Mac, but it's there on a Windows.
Here's a screenshot of the problem in FF6 on Win7 with jQM v1.0b3:
http://imageshack.us/photo/my-images/171/jqm.png/

IgitBuh commented Sep 22, 2011

Uhm ... no?
Why do you close this one having checked on Mac only? As Marcoos wrote the problem doesn't seem to be present in FF on a Mac, but it's there on a Windows.
Here's a screenshot of the problem in FF6 on Win7 with jQM v1.0b3:
http://imageshack.us/photo/my-images/171/jqm.png/

@gseguin gseguin reopened this Sep 22, 2011

@ghost ghost assigned scottjehl Sep 22, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 22, 2011

Contributor

Bah, thanks IJay, missed that. We're going to look into this today because IE and WP also have alignment issues.

Contributor

toddparker commented Sep 22, 2011

Bah, thanks IJay, missed that. We're going to look into this today because IE and WP also have alignment issues.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 22, 2011

Contributor

Just landed a fix for this:
42f7dcc

Closing, but please let me know if you see issues.

Contributor

toddparker commented Sep 22, 2011

Just landed a fix for this:
42f7dcc

Closing, but please let me know if you see issues.

@toddparker toddparker closed this Sep 22, 2011

@IgitBuh

This comment has been minimized.

Show comment
Hide comment
@IgitBuh

IgitBuh Sep 22, 2011

Just had a look at http://jquerymobile.com/test/docs/forms/forms-all.html and it looks fine there. Good job. :)

IgitBuh commented Sep 22, 2011

Just had a look at http://jquerymobile.com/test/docs/forms/forms-all.html and it looks fine there. Good job. :)

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Sep 30, 2011

Just tested change on 1.0rc1 and now my layout looks different.
I have two radiobuttons inside a container that has a "text-align: center;" style. Because of new float property the radio buttons are now aligned to the left (instead of centered within container).
I guess I can find a solution around this, but that code change was not completely backward compatible.

chrisben commented Sep 30, 2011

Just tested change on 1.0rc1 and now my layout looks different.
I have two radiobuttons inside a container that has a "text-align: center;" style. Because of new float property the radio buttons are now aligned to the left (instead of centered within container).
I guess I can find a solution around this, but that code change was not completely backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment