New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default page can't link to itself #1360

Closed
chasetec opened this Issue Apr 4, 2011 · 4 comments

Comments

Projects
None yet
3 participants
@chasetec

chasetec commented Apr 4, 2011

Example at: http://jsbin.com/afuhe4/ (go here, click on "one" link)

If I create a simple two page layout (within a single html) the first div-page (page1 in this example) is the default page displayed when there is no #pagename in the url. While viewing the default provided page clicking on any hyperlink that links back to itself (page1 in this example) will result is a blank page.

http://jsbin.com/afuhe4/edit

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 4, 2011

Contributor

First off, thanks for the example. I tried this and when I click to page 2, the footer navbar link to page 1 works for me in Chrome, Firefox and iPhone 4 anyway. The navbar on state seems to get confused on iPhone sometimes, but I'm not seeing a blank page.

Can you specify what device/OS version and steps to reproduce?

Contributor

toddparker commented Apr 4, 2011

First off, thanks for the example. I tried this and when I click to page 2, the footer navbar link to page 1 works for me in Chrome, Firefox and iPhone 4 anyway. The navbar on state seems to get confused on iPhone sometimes, but I'm not seeing a blank page.

Can you specify what device/OS version and steps to reproduce?

@chasetec

This comment has been minimized.

Show comment
Hide comment
@chasetec

chasetec Apr 4, 2011

It is not iOS specific. It occurs on iPhone, Safari (OSX), Firefox, etc...

Just click on the URL and then on the page ONE link. This must be done as the first action after navigating to the URL. If you've gone to page two then the page one link will work.

chasetec commented Apr 4, 2011

It is not iOS specific. It occurs on iPhone, Safari (OSX), Firefox, etc...

Just click on the URL and then on the page ONE link. This must be done as the first action after navigating to the URL. If you've gone to page two then the page one link will work.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 4, 2011

Contributor

Ah, I see now. I was clicking on two, then back to one. This is a regression. Thanks!

Contributor

toddparker commented Apr 4, 2011

Ah, I see now. I was clicking on two, then back to one. This is a regression. Thanks!

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Apr 5, 2011

Contributor

added tests to make sure links that reference the pages they are defined within don't transition Closed by b1da5f0

Contributor

johnbender commented Apr 5, 2011

added tests to make sure links that reference the pages they are defined within don't transition Closed by b1da5f0

@johnbender johnbender closed this Apr 5, 2011

brandonwoo pushed a commit that referenced this issue Apr 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment