Grouped radio buttons with long labels don't ellipsis #1419

Closed
o-sam-o opened this Issue Apr 11, 2011 · 8 comments

Comments

Projects
None yet
3 participants
@o-sam-o

o-sam-o commented Apr 11, 2011

If a radio's label is too long, the button group disappears off the edge of the screen.

e.g.
http://jsbin.com/osewi5/2/edit

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 28, 2011

Contributor

Good catch. Thanks so much for the JS Bin example!

Contributor

toddparker commented Apr 28, 2011

Good catch. Thanks so much for the JS Bin example!

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin May 13, 2011

Member

Would wrapping the content be acceptable? Or do we want to ellipsis?

Member

gseguin commented May 13, 2011

Would wrapping the content be acceptable? Or do we want to ellipsis?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 13, 2011

Contributor

I'd vote for wrapping since you probably need to see the full label value to make a decision. It should wrap so the text doesn't wrap under the radiobutton icon and stays lined up with the first row of text.

Contributor

toddparker commented May 13, 2011

I'd vote for wrapping since you probably need to see the full label value to make a decision. It should wrap so the text doesn't wrap under the radiobutton icon and stays lined up with the first row of text.

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin May 13, 2011

Member

Alright so that should work then: http://jsbin.com/osewi5/3 ?

Member

gseguin commented May 13, 2011

Alright so that should work then: http://jsbin.com/osewi5/3 ?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 13, 2011

Contributor

Looks good, but I think having the radiobutton stay top aligned might look even better.

Contributor

toddparker commented May 13, 2011

Looks good, but I think having the radiobutton stay top aligned might look even better.

@gseguin

This comment has been minimized.

Show comment
Hide comment
Member

gseguin commented May 13, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 13, 2011

Contributor

@gseguin - Looks great, just testing now on our mobile devices but so far so good on android and ios. Can you submit this as a pull request so I can bring it it with credit once I finish testing?

Contributor

toddparker commented May 13, 2011

@gseguin - Looks great, just testing now on our mobile devices but so far so good on android and ios. Can you submit this as a pull request so I can bring it it with credit once I finish testing?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 13, 2011

Contributor

This checks out everywhere so as you as you get a pull in, I'll land it. Thanks!

Contributor

toddparker commented May 13, 2011

This checks out everywhere so as you as you get a pull in, I'll land it. Thanks!

jaspermdegroot added a commit that referenced this issue May 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment