Skip to content

Grouped radio buttons with long labels don't ellipsis #1419

Closed
o-sam-o opened this Issue Apr 11, 2011 · 8 comments

3 participants

@o-sam-o
o-sam-o commented Apr 11, 2011

If a radio's label is too long, the button group disappears off the edge of the screen.

e.g.
http://jsbin.com/osewi5/2/edit

@toddparker

Good catch. Thanks so much for the JS Bin example!

@gseguin
jQuery Foundation member
gseguin commented May 13, 2011

Would wrapping the content be acceptable? Or do we want to ellipsis?

@toddparker

I'd vote for wrapping since you probably need to see the full label value to make a decision. It should wrap so the text doesn't wrap under the radiobutton icon and stays lined up with the first row of text.

@gseguin
jQuery Foundation member
gseguin commented May 13, 2011

Alright so that should work then: http://jsbin.com/osewi5/3 ?

@toddparker

Looks good, but I think having the radiobutton stay top aligned might look even better.

@gseguin
jQuery Foundation member
gseguin commented May 13, 2011
@gseguin gseguin pushed a commit that referenced this issue May 13, 2011
Ghislain Seguin Fixed #1419: Grouped radio buttons with long labels don't ellipsis f929e90
@toddparker

@gseguin - Looks great, just testing now on our mobile devices but so far so good on android and ios. Can you submit this as a pull request so I can bring it it with credit once I finish testing?

@toddparker

This checks out everywhere so as you as you get a pull in, I'll land it. Thanks!

@timmywil timmywil pushed a commit that referenced this issue Oct 24, 2011
Ghislain Seguin Fixed #1419: Grouped radio buttons with long labels don't ellipsis da4fa08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.