New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser title update for Ajax links (issue 581) improperly escapes HTML entities #1447

Closed
gfortytwo opened this Issue Apr 13, 2011 · 9 comments

Comments

Projects
None yet
9 participants
@gfortytwo

This seems to be a problem with the feature added to A4 in this issue:

#581

If the ajax-retrieved page has a "title" tag in the header whose text contains an HTML entity (of the form ampersand-something-something-semicolon) then when the browser title is updated it shows the literal entity (the HTML source) rather than the translated character, implying that the ampersand/semicolon are being escaped.

The same problem does not seem to occur if a "data-title" attribute is provided on a "page" div.

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Apr 18, 2011

Test scenario:

  • first page with link to another page (no special target or rel specified)
  • the linked page should have a title containing encoded html entities, for instance: <title>Communiqu& eacute;s</title> (space after ampersand just there for entity to be visible and not decoded by issues page)

When you click on that link for the first time, the new page title shows: "Communiqu& eacute;s".
Strangely enough, when you go back and then forth again you will see the title with the html entity correctly decoded: "Communiqués".

Reproduced on both iphone4 and Chrome - character encoding: utf-8 defined in meta of both pages.

Test scenario:

  • first page with link to another page (no special target or rel specified)
  • the linked page should have a title containing encoded html entities, for instance: <title>Communiqu& eacute;s</title> (space after ampersand just there for entity to be visible and not decoded by issues page)

When you click on that link for the first time, the new page title shows: "Communiqu& eacute;s".
Strangely enough, when you go back and then forth again you will see the title with the html entity correctly decoded: "Communiqués".

Reproduced on both iphone4 and Chrome - character encoding: utf-8 defined in meta of both pages.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 19, 2011

Contributor

Thanks for the detailed report. We'll take a look at our code for the title parsing.

Contributor

toddparker commented Apr 19, 2011

Thanks for the detailed report. We'll take a look at our code for the title parsing.

@aknosis

This comment has been minimized.

Show comment
Hide comment
@aknosis

aknosis May 17, 2011

+1 for this, I use the same <title> for web and mobile and in web I get proper entity rendering yet the escaped versions on mobile.

aknosis commented May 17, 2011

+1 for this, I use the same <title> for web and mobile and in web I get proper entity rendering yet the escaped versions on mobile.

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Jun 21, 2011

Reproduced in beta1

Reproduced in beta1

@jocull

This comment has been minimized.

Show comment
Hide comment
@jocull

jocull Aug 1, 2011

This is happening for me as well.

jocull commented Aug 1, 2011

This is happening for me as well.

@ghost ghost assigned johnbender Aug 8, 2011

@DominicTobias

This comment has been minimized.

Show comment
Hide comment
@DominicTobias

DominicTobias Oct 4, 2011

Hi I am also having this issue - any news on it or ideas for a quickfix?

Hi I am also having this issue - any news on it or ideas for a quickfix?

@AGrunewald

This comment has been minimized.

Show comment
Hide comment
@AGrunewald

AGrunewald Oct 18, 2011

Any updates on this ?

Any updates on this ?

@AGrunewald

This comment has been minimized.

Show comment
Hide comment
@AGrunewald

AGrunewald Oct 21, 2011

So this was planned for RC2 and got pushed out to 1.0? Are you confident that it will be in 1.0 or is there a chance that it will get pushed out again?

So this was planned for RC2 and got pushed out to 1.0? Are you confident that it will be in 1.0 or is there a chance that it will get pushed out again?

@ghost ghost assigned gseguin Oct 28, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 28, 2011

Contributor

We're never 100% sure, but it's still on our radar for 1.0

Contributor

toddparker commented Oct 28, 2011

We're never 100% sure, but it's still on our radar for 1.0

Wilto added a commit that referenced this issue Nov 4, 2011

Merge pull request #2934 from garann/master
Issue #1447 - unescape entities in page titles

timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011

timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011

Merge pull request #2934 from garann/master
Issue #1447 - unescape entities in page titles

@gseguin gseguin closed this Nov 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment