New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tops of pages missing after dialog click in Safari and iPhone #1461

Closed
gerbs opened this Issue Apr 16, 2011 · 14 comments

Comments

Projects
None yet
8 participants
@gerbs

gerbs commented Apr 16, 2011

In the iPhone Safari and regular Safari browser (adjusted to about the size of the iPhone browser), the tops of pages go missing after clicking on a dialog button and then returning to the page that has the dialog button..

You can reproduce this on the jQuery demo pages. Go to http://jquerymobile.com/demos/1.0a4.1/#docs/pages/docs-dialogs.html on the iPhone, and click any of the dialog buttons. After returning to the page, notice how the top of the page is missing, including the header. The further down the page you go and click on a dialog button, the more of the top of the page will be gone.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 18, 2011

Contributor

This is a really bad regression, not sure how we didn't notice this in testing. This is a blocker.

Contributor

toddparker commented Apr 18, 2011

This is a really bad regression, not sure how we didn't notice this in testing. This is a blocker.

@VTWoods

This comment has been minimized.

Show comment
Hide comment
@VTWoods

VTWoods Apr 20, 2011

Contributor

I also experience this issue on an iPod Touch iOS 4.1. After the dialog box, the top of the page is missing and the page is rendered incorrectly.

Contributor

VTWoods commented Apr 20, 2011

I also experience this issue on an iPod Touch iOS 4.1. After the dialog box, the top of the page is missing and the page is rendered incorrectly.

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Apr 21, 2011

Contributor

looks like we just need to set focus after the silentscroll event fires.

Contributor

scottjehl commented Apr 21, 2011

looks like we just need to set focus after the silentscroll event fires.

@ghost ghost assigned jblas Apr 21, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Apr 21, 2011

Contributor

Fix checked in:

2d2e6d7

Contributor

jblas commented Apr 21, 2011

Fix checked in:

2d2e6d7

@jblas jblas closed this Apr 21, 2011

@sebabal

This comment has been minimized.

Show comment
Hide comment
@sebabal

sebabal May 4, 2011

I tried the fix but it did not work for me. Using safari windows or iPod

sebabal commented May 4, 2011

I tried the fix but it did not work for me. Using safari windows or iPod

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 4, 2011

Contributor

@sebabal

Do you have an example URL we can see? I can't repro this since the fix.

Contributor

jblas commented May 4, 2011

@sebabal

Do you have an example URL we can see? I can't repro this since the fix.

@MikeTek

This comment has been minimized.

Show comment
Hide comment
@MikeTek

MikeTek May 5, 2011

I'm having this problem too. Closing dialog kills the top of the page. You guys are hosting .js files so not sure how to implement a fix from my end.

MikeTek commented May 5, 2011

I'm having this problem too. Closing dialog kills the top of the page. You guys are hosting .js files so not sure how to implement a fix from my end.

@sebabal

This comment has been minimized.

Show comment
Hide comment
@sebabal

sebabal May 5, 2011

Sorry for this late reply...
@jblas sorry I don't have a public URL yet, although it is strange that you can't reproduce it, maybe it is something on my end.

On my case it was happening whether it was a dialog or page loaded by ajax (using the multi-page feature). The only workaround that I found was to stop using the data-position="fixed" on the header

sebabal commented May 5, 2011

Sorry for this late reply...
@jblas sorry I don't have a public URL yet, although it is strange that you can't reproduce it, maybe it is something on my end.

On my case it was happening whether it was a dialog or page loaded by ajax (using the multi-page feature). The only workaround that I found was to stop using the data-position="fixed" on the header

@MikeTek

This comment has been minimized.

Show comment
Hide comment
@MikeTek

MikeTek May 6, 2011

I had been using the data-position="fixed" in the headers and noticed this problem. Removed it, problem persists. At a loss at this point.

MikeTek commented May 6, 2011

I had been using the data-position="fixed" in the headers and noticed this problem. Removed it, problem persists. At a loss at this point.

@MikeTek

This comment has been minimized.

Show comment
Hide comment
@MikeTek

MikeTek May 6, 2011

This still happening on your demo site. I'm in Chrome. If I visit the dialogs page - http://jquerymobile.com/demos/1.0a4.1/#docs/pages/docs-dialogs.html - scroll down and click the "An Alternative Color Scheme" button, upon closing the top of the page is cut off.

Same behavior in iOS 4.

MikeTek commented May 6, 2011

This still happening on your demo site. I'm in Chrome. If I visit the dialogs page - http://jquerymobile.com/demos/1.0a4.1/#docs/pages/docs-dialogs.html - scroll down and click the "An Alternative Color Scheme" button, upon closing the top of the page is cut off.

Same behavior in iOS 4.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 6, 2011

Contributor

@MikeTek,

The 1.0a4.1 URL you reference is static, that is, it is a snapshot of that alpha that doesn't change. You want to test against the latest greatest from our code repository, you have to use:

http://jquerymobile.com/test/

Contributor

jblas commented May 6, 2011

@MikeTek,

The 1.0a4.1 URL you reference is static, that is, it is a snapshot of that alpha that doesn't change. You want to test against the latest greatest from our code repository, you have to use:

http://jquerymobile.com/test/

@aktsinha

This comment has been minimized.

Show comment
Hide comment
@aktsinha

aktsinha May 25, 2011

I do not want to use the the nightly build (its causing some issues for me). Could someone please point me to the changes I would need from alpha4.1? I tried this commit, also reFocus within setTimeout , but thats not helping.
Thanks
Ankit

aktsinha commented May 25, 2011

I do not want to use the the nightly build (its causing some issues for me). Could someone please point me to the changes I would need from alpha4.1? I tried this commit, also reFocus within setTimeout , but thats not helping.
Thanks
Ankit

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 25, 2011

Contributor

Kin linked to the relevant commit above in this thread:
2d2e6d7

Contributor

toddparker commented May 25, 2011

Kin linked to the relevant commit above in this thread:
2d2e6d7

@aktsinha

This comment has been minimized.

Show comment
Hide comment
@aktsinha

aktsinha May 26, 2011

Hi, this commit alone does NOT solve the issue. Perhaps there have been lots of changes in Screen Focus Management.
My problem is with data-position fixed header/footer: Their layout is messed up on returning from a dialogue or Ajax Navigation. It gets fixed (footer returns to expected position) when I manually select some input element.
So is there someway I can force the screen to layout again? Something like $.mobile.activePage.layout or repaint, layoutFooter, setFocus/removeFocus....
Also, when is your next release planned for, if it is within a week or so I will wait for it.

aktsinha commented May 26, 2011

Hi, this commit alone does NOT solve the issue. Perhaps there have been lots of changes in Screen Focus Management.
My problem is with data-position fixed header/footer: Their layout is messed up on returning from a dialogue or Ajax Navigation. It gets fixed (footer returns to expected position) when I manually select some input element.
So is there someway I can force the screen to layout again? Something like $.mobile.activePage.layout or repaint, layoutFooter, setFocus/removeFocus....
Also, when is your next release planned for, if it is within a week or so I will wait for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment