Corner styling issue with listview refresh on growing lists #1470

Closed
pamelafox opened this Issue Apr 19, 2011 · 5 comments

Projects

None yet

4 participants

@pamelafox

Steps to replicate:
1. Create an empty UL in HTML.
2. Add LIs to it one at a time, calling refresh after each one.
3. The top LI will be mis-styled, with the bottom-corner class names still applied even after subsequent LI additions.
Demonstration: http://imagine-it.org/jquerymobile/listview_wrong.html

Workaround is to only refresh after adding all of them: http://imagine-it.org/jquerymobile/listview_right.html

@toddparker

Thanks for the demo pages. We'll take a look.

@hakanson

Probably should fix this one along with jquery/jquery-mobile#1450 since the both have to do with clearing or applying corner styling to the list. It would be nice if the listview.filter could call into the listview widget to apply corner styling, since it is not only the list, but the .ui-li-link-alt and .ui-li-thumb children that get corner styling as well. I can't seem to find a clean way of doing that.

Also, it looks like there is another bug on applying ui-corner-tl or ui-corner-bl the .ui-li-thumb, since this code comes before the call to self._itemApply, which is what adds the .ui-li-thumb class. You can see this by looking closely at "Thumbnail, split button list" at the lists inset example.

@hakanson

Looks like jquery/jquery-mobile#1576 by @mfn is a duplicate of this. However, the bottom corner is easier to see in that example because it is data-role="list-divider" (see image @ http://i.imgur.com/3lkFs.png?7150 ).

@gseguin
jQuery Foundation member

I created a fiddle for that issue: http://jsfiddle.net/ghislain/d8gSH/

@toddparker

@hakanson - Yep, I've added the "gseguin" tag to all the list issues so Ghislain can look at these list issues all at once. Feel free to tag related issues the same way.

@gseguin gseguin pushed a commit to gseguin/jquery-mobile that referenced this issue May 18, 2011
Ghislain Seguin Added test for issue #1470
Corner styling issue with listview refresh on growing lists
9dcbee5
@gseguin gseguin pushed a commit to gseguin/jquery-mobile that referenced this issue May 18, 2011
Ghislain Seguin Fix for issue #1470
Modified _removeCorners so it takes which corner to remove as a parameter
Now removes the bottom corners of first list item if it is followed by another one.
fc369ee
@gseguin gseguin pushed a commit to gseguin/jquery-mobile that referenced this issue May 18, 2011
Ghislain Seguin Fix for #1470
Corner styling issue with listview refresh on growing lists
bd06861
@gseguin gseguin was assigned Jun 20, 2011
@gseguin gseguin closed this Jun 29, 2011
@timmywil timmywil pushed a commit that referenced this issue Oct 24, 2011
Ghislain Seguin Fix for #1470
Corner styling issue with listview refresh on growing lists
ef89fe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment