New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page change css error #1507

Closed
badtoto opened this Issue Apr 22, 2011 · 9 comments

Comments

Projects
None yet
4 participants
@badtoto

badtoto commented Apr 22, 2011

when page change , elements with class "ui-btn-inner" where be height 100%,
it is effected by class "ui-mobile-viewport-transitioning"

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 28, 2011

Contributor

Hello. Can you please post a demo page in JS Bin or JS Fiddle and detailed steps to reproduce, including device/browser versions you see this issue on? Thanks!

Contributor

toddparker commented Apr 28, 2011

Hello. Can you please post a demo page in JS Bin or JS Fiddle and detailed steps to reproduce, including device/browser versions you see this issue on? Thanks!

@badtoto

This comment has been minimized.

Show comment
Hide comment
@badtoto

badtoto May 23, 2011

a simple page like below

<title>jQuery TEST</title> <script type="text/javascript" src="http://code.jquery.com/jquery.min.js"></script> <script type="text/javascript" src="http://code.jquery.com/mobile/latest/jquery.mobile.js"></script>

First page

<div data-role="content">   
  <p><a href="#second" data-role="button" data-iconpos="right" data-icon="arrow-r">transit to second page</a></p>   
</div>

<div data-role="footer" class="ui-bar">
    <a  href="#" data-role="button" data-icon="arrow-l">back</a>
</div>
<div data-role="header">
  <h1>Second page</h1>
</div>

<div data-role="content">   
  <p><a href="#first" data-role="button"data-icon="arrow-l">back to first page</a></p>  
</div>

<div data-role="footer" class="ui-bar">
    <a  href="#" data-role="button" data-icon="arrow-l">back</a>
</div>

badtoto commented May 23, 2011

a simple page like below

<title>jQuery TEST</title> <script type="text/javascript" src="http://code.jquery.com/jquery.min.js"></script> <script type="text/javascript" src="http://code.jquery.com/mobile/latest/jquery.mobile.js"></script>

First page

<div data-role="content">   
  <p><a href="#second" data-role="button" data-iconpos="right" data-icon="arrow-r">transit to second page</a></p>   
</div>

<div data-role="footer" class="ui-bar">
    <a  href="#" data-role="button" data-icon="arrow-l">back</a>
</div>
<div data-role="header">
  <h1>Second page</h1>
</div>

<div data-role="content">   
  <p><a href="#first" data-role="button"data-icon="arrow-l">back to first page</a></p>  
</div>

<div data-role="footer" class="ui-bar">
    <a  href="#" data-role="button" data-icon="arrow-l">back</a>
</div>

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 25, 2011

Contributor

Pasting code into an issue doesn't display correctly and is hard to debug. Please post code in Git, JS Fiddle or jsBin along with a detailed set of sets to reproduce and platform version info.

Contributor

toddparker commented May 25, 2011

Pasting code into an issue doesn't display correctly and is hard to debug. Please post code in Git, JS Fiddle or jsBin along with a detailed set of sets to reproduce and platform version info.

@badtoto

This comment has been minimized.

Show comment
Hide comment

badtoto commented May 25, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 25, 2011

Contributor

Thanks for the demo. We'll take a look.

Contributor

toddparker commented May 25, 2011

Thanks for the demo. We'll take a look.

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge May 27, 2011

Contributor

Can you please test in the latest as it appears to be fixed with pull request: #1723

Contributor

eddiemonge commented May 27, 2011

Can you please test in the latest as it appears to be fixed with pull request: #1723

@badtoto

This comment has been minimized.

Show comment
Hide comment
@badtoto

badtoto Jun 2, 2011

it is fixed, thank you :)

badtoto commented Jun 2, 2011

it is fixed, thank you :)

@badtoto badtoto closed this Jun 2, 2011

@badtoto badtoto reopened this Jun 6, 2011

@badtoto

This comment has been minimized.

Show comment
Hide comment
@badtoto

badtoto Jun 6, 2011

in the lastest version, it occurs

http://jsbin.com/ijixi4/edit

badtoto commented Jun 6, 2011

in the lastest version, it occurs

http://jsbin.com/ijixi4/edit

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Jun 6, 2011

Contributor

Yeah, we had to revert this fix because it was causing other issues.

Contributor

toddparker commented Jun 6, 2011

Yeah, we had to revert this fix because it was causing other issues.

@ghost ghost assigned scottjehl Jun 6, 2011

@scottjehl scottjehl closed this in e1ed42d Jun 9, 2011

nsaleh added a commit to nsaleh/jquery-mobile that referenced this issue Aug 16, 2011

removed height:100% on inner buttons. I think this was a carryover fr…
…om the old listview markup, but in testing we found no regressions by removing this. Fixes #1507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment