New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phonegap: Pages with data-ajax="false" on form fail to load #1580

Closed
jblas opened this Issue May 6, 2011 · 5 comments

Comments

Projects
None yet
1 participant
@jblas
Contributor

jblas commented May 6, 2011

This problem was originally reported in issue 1578 where one user was trying to test the fix for 1578 but was experiencing a page load that never seems to finish. That is, the JQM load message just sits there spinning.

The page that was being loaded was a markup fragment that contained a data-role="page" div with a form that had @data-ajax="false". If I removed the @data-ajax attribute things seemed to load just fine.

@ghost ghost assigned jblas May 6, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 6, 2011

Contributor

I should've noted in the original report above that the hang can be seen in a phonegap app loaded in the iOS iPhone 4.2 Emulator on the Mac.

Contributor

jblas commented May 6, 2011

I should've noted in the original report above that the hang can be seen in a phonegap app loaded in the iOS iPhone 4.2 Emulator on the Mac.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 6, 2011

Contributor

This does NOT seem to be a problem with phonegap on Android.

Contributor

jblas commented May 6, 2011

This does NOT seem to be a problem with phonegap on Android.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 6, 2011

Contributor

Ok, found the problem ... it is real. :-)

In the $.ajax() callback, we look for elements with @href, @src, and @data-ajax="false" elements, the code then assumes that matching elements will have either @href or @src, which of course forms don't ... they have @action ... so the code throws an exception because thisUrl is undefined.

Patch on its way.

Contributor

jblas commented May 6, 2011

Ok, found the problem ... it is real. :-)

In the $.ajax() callback, we look for elements with @href, @src, and @data-ajax="false" elements, the code then assumes that matching elements will have either @href or @src, which of course forms don't ... they have @action ... so the code throws an exception because thisUrl is undefined.

Patch on its way.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas May 6, 2011

Contributor

Fix landed on the HEAD:

e597ccb

Contributor

jblas commented May 6, 2011

Fix landed on the HEAD:

e597ccb

@jblas jblas closed this May 6, 2011

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 6, 2011

Confirm fixed in 4.3 iphone simulator on osx.

ghost commented May 6, 2011

Confirm fixed in 4.3 iphone simulator on osx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment