New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple-selcet - dialog opening #1692

Closed
kurzweg opened this Issue May 23, 2011 · 4 comments

Comments

Projects
None yet
4 participants
@kurzweg

kurzweg commented May 23, 2011

When you open a muliple-select dialog which doesn't fit to the screen, make some selections, close the dialog and open it again it will not open in a fullscreen dialog. However if you close the none fullscreen dialog again an open the dialog field once more you will again have the fullscreen dialog. Going on it will alwas change between fullscreen and none-fullscreen dialog.

tested in mobile safari (iPad 2 and iPhone 3GS), safari, chrome and firefox

to recreate:

  1. go to http://jquerymobile.com/test/docs/forms/forms-selects.html -> 'Choose state(s):'
  2. select some states (opens fullscreen)
  3. close the (fullscreen) dialog
  4. reopen the dialog (it will now be a regular one)
  5. close the (regular dialog)
  6. open again (it will once more be fullscreen)
  7. see 3.
@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 23, 2011

Contributor

Please submit detailed information on how to reproduce the issue, a demo test page on JS Bin using the latest build, and info on what browser/platform you're seeing an issue. Thanks.

Contributor

toddparker commented May 23, 2011

Please submit detailed information on how to reproduce the issue, a demo test page on JS Bin using the latest build, and info on what browser/platform you're seeing an issue. Thanks.

@kurzweg

This comment has been minimized.

Show comment
Hide comment
@kurzweg

kurzweg May 23, 2011

sorry didn't expected someone to answer that quickly so i saved by and by :)

kurzweg commented May 23, 2011

sorry didn't expected someone to answer that quickly so i saved by and by :)

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 23, 2011

Contributor

Heh. Not normally that fast, but we try to respond quickly. Thanks for the details!

Contributor

toddparker commented May 23, 2011

Heh. Not normally that fast, but we try to respond quickly. Thanks for the details!

@marcoos

This comment has been minimized.

Show comment
Hide comment
@marcoos

marcoos May 24, 2011

After reading kurzweg's description, I think it's related to #1626 (or probably even the same issue).

marcoos commented May 24, 2011

After reading kurzweg's description, I think it's related to #1626 (or probably even the same issue).

pauln added a commit to pauln/jquery-mobile that referenced this issue Jun 1, 2011

Call close() function when clicking close button on dialog for select…
…s with menuType="page" rather than falling back to default click handler's window.history.back() call. This fixes issue #1692

@scottjehl scottjehl closed this in ada4673 Jul 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment