Navbar: data-iconpos is ignored #1797

Closed
aturlov opened this Issue Jun 8, 2011 · 6 comments

Projects

None yet

8 participants

@aturlov
aturlov commented Jun 8, 2011

Links that simulate buttons in Navbar ignore data-iconpos attribute therefore if data-icon is present the icon is always displayed on the top of text. I don't know if this is by design but in any case that behavior does not allow achieve standard iPhone icon-only look an feel.

@aturlov
aturlov commented Jun 8, 2011

Example:

    <div data-role="footer" data-theme="b">
        <div data-role="navbar">
            <ul>
                <li><a href="#" data-role="button" data-icon="info" data-iconpos="notext">Info</a></li>
                <li><a href="#" data-role="button" data-icon="search"  data-iconpos="notext">Search</a></li>
                <li><a href="#" data-role="button" data-icon="delete" data-iconpos="notext">Cancel</a></li>
            </ul>
        </div>
    </div>
@pravinkmrr

ya its by default set as top. if you didn't mention icon position it will display only text. i think you want to add only icon is it?

@pravinkmrr pravinkmrr added a commit to pravinkmrr/jquery-mobile that referenced this issue Jun 20, 2011
@pravinkmrr pravinkmrr Navbar: data-iconpos is ignored Issue #1797 Fixed issue 23b7765
@pravinkmrr pravinkmrr added a commit to pravinkmrr/jquery-mobile that referenced this issue Jun 20, 2011
@pravinkmrr pravinkmrr Navbar: data-iconpos is ignored #1797 Issue fixed 4178180
@scottjehl scottjehl was assigned Jun 20, 2011
@MissVeronica

I'm sorry but an issue is fixed when I can find the fix included in the JQuery Mobile nightly build until then it's NOT fixed even if it was done 3 weeks ago
For all tests I'm using http://code.jquery.com/mobile/latest/jquery.mobile.js

@eddiemonge
Contributor

Thats because this issue has not been fixed. No code has been submitted via pull request.

@johnbender johnbender was assigned Aug 7, 2011
@toddparker toddparker added a commit that closed this issue Oct 12, 2011
@toddparker toddparker Re-vamped the navbar docs to fix incorrect info about icon positionin…
…g and theming. Fixes #1858, Fixes #1797, Fixes #2667, Fixes #1180, Fixes #2373

The docs incorrectly stated that the icon position could be set per
link, but this is intended as a global setting for the navbar parent.
This is working as designed and helps with visual consistency. If icon
positioning needs to be be adjusted per link, you will need to manually
apply the right classes through JS and may need to tweak CSS because
top/bottom and left/right positions have different heights.
15e984e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment