New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: data-iconpos is ignored #1797

Closed
aturlov opened this Issue Jun 8, 2011 · 6 comments

Comments

Projects
None yet
8 participants
@aturlov

aturlov commented Jun 8, 2011

Links that simulate buttons in Navbar ignore data-iconpos attribute therefore if data-icon is present the icon is always displayed on the top of text. I don't know if this is by design but in any case that behavior does not allow achieve standard iPhone icon-only look an feel.

@aturlov

This comment has been minimized.

Show comment
Hide comment
@aturlov

aturlov Jun 8, 2011

Example:

    <div data-role="footer" data-theme="b">
        <div data-role="navbar">
            <ul>
                <li><a href="#" data-role="button" data-icon="info" data-iconpos="notext">Info</a></li>
                <li><a href="#" data-role="button" data-icon="search"  data-iconpos="notext">Search</a></li>
                <li><a href="#" data-role="button" data-icon="delete" data-iconpos="notext">Cancel</a></li>
            </ul>
        </div>
    </div>

aturlov commented Jun 8, 2011

Example:

    <div data-role="footer" data-theme="b">
        <div data-role="navbar">
            <ul>
                <li><a href="#" data-role="button" data-icon="info" data-iconpos="notext">Info</a></li>
                <li><a href="#" data-role="button" data-icon="search"  data-iconpos="notext">Search</a></li>
                <li><a href="#" data-role="button" data-icon="delete" data-iconpos="notext">Cancel</a></li>
            </ul>
        </div>
    </div>
@pravinkmrr

This comment has been minimized.

Show comment
Hide comment
@pravinkmrr

pravinkmrr Jun 20, 2011

ya its by default set as top. if you didn't mention icon position it will display only text. i think you want to add only icon is it?

pravinkmrr commented Jun 20, 2011

ya its by default set as top. if you didn't mention icon position it will display only text. i think you want to add only icon is it?

pravinkmrr added a commit to pravinkmrr/jquery-mobile that referenced this issue Jun 20, 2011

@pravinkmrr

This comment has been minimized.

Show comment
Hide comment

pravinkmrr added a commit to pravinkmrr/jquery-mobile that referenced this issue Jun 20, 2011

@ghost ghost assigned scottjehl Jun 20, 2011

@MissVeronica

This comment has been minimized.

Show comment
Hide comment
@MissVeronica

MissVeronica Jul 8, 2011

I'm sorry but an issue is fixed when I can find the fix included in the JQuery Mobile nightly build until then it's NOT fixed even if it was done 3 weeks ago
For all tests I'm using http://code.jquery.com/mobile/latest/jquery.mobile.js

MissVeronica commented Jul 8, 2011

I'm sorry but an issue is fixed when I can find the fix included in the JQuery Mobile nightly build until then it's NOT fixed even if it was done 3 weeks ago
For all tests I'm using http://code.jquery.com/mobile/latest/jquery.mobile.js

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge Jul 8, 2011

Contributor

Thats because this issue has not been fixed. No code has been submitted via pull request.

Contributor

eddiemonge commented Jul 8, 2011

Thats because this issue has not been fixed. No code has been submitted via pull request.

@ducas

This comment has been minimized.

Show comment
Hide comment
@ducas

ducas commented Jul 22, 2011

@ghost ghost assigned johnbender Aug 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment