Nightly build - dialog box no longer rounded corners #1826

Closed
fredramsey opened this Issue Jun 14, 2011 · 19 comments

Projects

None yet

3 participants

@fredramsey

Got the latest from here:

http://jquerymobile.com/blog/2011/04/16/latest/

Which makes listview filtering FAST! But the dialog boxes are now full screen, no rounded corners :-(

Please help!

@toddparker
Contributor

Can you provide details on the browser/version and a simple test case using latest in jsBin?
http://jsbin.com/awufo3/edit

@jblas
Contributor
jblas commented Jun 14, 2011

Also, do you see rounded corners when you visit this url and show one of the dialogs?

http://jquerymobile.com/test/#/test/docs/pages/docs-dialogs.html

@fredramsey

I do see rounded corners on the demo. I am using Safari for Windows.

@fredramsey

I tried adding code in that link, but it kept saying unsaved and just incremented the version number?

@fredramsey

I think I got the code added now.

@fredramsey

Sorry about the non-running code - I'll get something to work and post when I do.

@fredramsey

Ok, I finally have something that shows the problem, and it works in the editor (sorry about all the mis-fires, I've not worked with git before).

http://jsbin.com/awufo3/9/edit

This used to work. I think it might be the fact that I'm opening the dialog box with a $.mobile.changePage. But again, that worked before, and I really need to be able to open the dialog box programmatically, especially in my bigger app.

Thanks so much for your time.

-Fred Ramsey
http://darwinsoftware.com

@jblas jblas was assigned Jun 15, 2011
@jblas
Contributor
jblas commented Jun 15, 2011

@fredramsey

Thanks for the example. Just an FYI, I changed the signature to changePage() on the HEAD so that it is much simpler now. Check out the "Refactor Navigation Code (Beta 1)" section in this document:

https://github.com/jquery/jquery-mobile/wiki/Refactor:-Navigation-Plan

That said, I did put in some code to remap the old style calling convention into the new way, but that will be removed either in the next version or when we go 1.0.

@fredramsey

Thanks for the info. Is there an example of the new call so I can change my code?

And I take it you did see what I was talking about. Any idea of a timeframe on fixing it? I'd like to release my larger app that uses that heavily sometime soon, but I need that faster listview filter capability.

Thanks for your valuable time.

-Fred Ramsey
http://darwinsoftware.com

@jblas
Contributor
jblas commented Jun 15, 2011

@fredramsey

I have a fix in my local tree. I'm running the unit tests. Right now. I'll land as soon as I verify nothing regressed.

  • Kin
@jblas
Contributor
jblas commented Jun 15, 2011

I'm marking this critical because I broke the display of @data-role="dialog" markup. Dialogs invoked with a data-rel="dialog" were unaffected by the refactoring because the role is parsed out and passed into changePage() in our global click handler.

@fredramsey

I assume changes are being made to the latest/nightly builds, as I just tested my sample code by taking off data-role="dialog" and just leaving data-rel="dialog", and now the dialog box doesn't come up at all....

http://jsbin.com/awufo3/10/edit

@jblas
Contributor
jblas commented Jun 15, 2011

The data-rel="dialog" attribute is supposed to go on the link that invokes the dialog, not the markup that is the dialog. I just tested it without any changes and it works fine. I also know it works because this page works just fine:

http://jquerymobile.com/test/#/test/docs/pages/docs-dialogs.html

@fredramsey

But I'm not using a link to open the dialog, I'm doing it with changepage. That was kind of the point. That was working in the released version, not in the latest, back to: http://jsbin.com/awufo3/9/edit

I'm not trying to be difficult. I understand about data-rel now. But data-role="dialog" is what I need to work with changepage.

@jblas
Contributor
jblas commented Jun 15, 2011

@fredramsey

I understand what you are doing. I have a fix for it, I was just trying to point out why your use of data-rel wasn't working in your comment above. In my local tree both cases work.

I will land it once I figure out why one of the unit tests, for a very specific usage case, is failing now.

@jblas
Contributor
jblas commented Jun 15, 2011

Also, as a side note, I wasn't suggesting that you use data-rel="dialog" I was merely notating that for others so they know what broke and what works.

@fredramsey

Thanks for understanding. I'll shut up now :-)

@jblas
Contributor
jblas commented Jun 16, 2011

I just landed the fix for this:

8b6d14b

@jblas jblas closed this Jun 16, 2011
@fredramsey

Excellent! Thanks so much. Works great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment