New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No page transition used when hitting the browser forward button #1833

Closed
jblas opened this Issue Jun 15, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@jblas
Contributor

jblas commented Jun 15, 2011

@scottjehl told me about this one:

If you load a JQM application, then navigate to another page, you see a slide transition. If you hit the browser back button, you see a reverse slide transition to the initial application page. If you then hit the browser's forward button, you are taken to the page you previously visited instantly with no transition.

Looking into it, the logic for calculating the transition to use in this situation is pretty much the same as it was prior to the navigation code refactor I did. The one difference is that the initial page used to have a boolean false value as its value for the transition property of its urlHistory stack entry. Now it has "none" so the old logic allows the "none" to be used as the transition for the new page.

@ghost ghost assigned jblas Jun 15, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Jun 15, 2011

Contributor

Landed fix for this on HEAD:

d2f1153

Contributor

jblas commented Jun 15, 2011

Landed fix for this on HEAD:

d2f1153

@jblas jblas closed this Jun 15, 2011

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 15, 2011

Contributor

nice! thanks Kin :)

On Jun 15, 2011, at 6:31 PM, jblas wrote:

Landed fix for this on HEAD:

d2f1153

Reply to this email directly or view it on GitHub:
#1833 (comment)

Contributor

scottjehl commented Jun 15, 2011

nice! thanks Kin :)

On Jun 15, 2011, at 6:31 PM, jblas wrote:

Landed fix for this on HEAD:

d2f1153

Reply to this email directly or view it on GitHub:
#1833 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment