New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active class not being removed from dialogs #1839

Closed
toddparker opened this Issue Jun 16, 2011 · 0 comments

Comments

Projects
None yet
2 participants
@toddparker
Contributor

toddparker commented Jun 16, 2011

If you nav to a dialog in latest, click the cancel button to close it, then re-open the close button will still be blue (active).

@ghost ghost assigned scottjehl Jun 16, 2011

@scottjehl scottjehl closed this in 1dd6608 Jun 17, 2011

jaspermdegroot added a commit that referenced this issue Jan 3, 2013

Dialog: Removed code that removes active state from buttons on pagehi…
…de. Fixes #5111.

The code was added because close buttons still had active state when you closed and re-opened a dialog (#1839). I tested without the code and that issue doesn't occur anymore (nav takes care of removing active state).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment