Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Controlgroup should filter on visible buttons when adding first and last classes #1929

Closed
gseguin opened this issue Jun 24, 2011 · 1 comment
Closed

Controlgroup should filter on visible buttons when adding first and last classes #1929

gseguin opened this issue Jun 24, 2011 · 1 comment
Assignees
@gseguin

Comments

@gseguin
Copy link
Contributor

gseguin commented Jun 24, 2011

If you hide the first or last button in a control group and then call refresh on it, it won't add the right classes to the newly promoted first/last button.
http://jsbin.com/ecexaj/38
@ghost ghost assigned gseguin Jun 24, 2011
@gseguin
Copy link
Contributor Author

gseguin commented Jun 24, 2011

Adding a .filter( ":visible" ) seems to do the trick: http://jsbin.com/ecexaj/39

gseguin added a commit that referenced this issue Jun 24, 2011
@gseguin
Fixed issue #1929
226873d
@gseguin gseguin closed this as completed Jun 24, 2011
gseguin added a commit that referenced this issue Jun 25, 2011
@gseguin
Revert "Fixed issue #1929" as it is breaking horizontal controlgroups
00297af 
This reverts commit 226873d.
gseguin added a commit that referenced this issue Jun 25, 2011
@gseguin
Disabled tests for issue #1929 until I find a better fix for it
66aed02
@gseguin gseguin reopened this Jun 25, 2011
gseguin added a commit that referenced this issue Jun 25, 2011
@gseguin
Fix for issue #1929 (second attempt)
ebd4eec
gseguin added a commit that referenced this issue Jun 25, 2011
@gseguin
Readded tests for issue #1929
52a0c10
@gseguin gseguin closed this as completed Jun 25, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gseguin gseguin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gseguin