New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a dialog close button is clicked over a page header button, it clicks that too #1986

Closed
pamelafox opened this Issue Jun 29, 2011 · 10 comments

Comments

Projects
None yet
5 participants
@pamelafox

pamelafox commented Jun 29, 2011

I have a multi-page app with headers like so:

  <div data-role="header" data-theme="b"> 
    <a href="#home" data-icon="home" data-iconpos="notext" data-direction="reverse" class="ui-btn-left jqm-home">Home</a>-->
    <h1>My App</h1> 
    <a href="#settings" data-icon="gear" data-iconpos="notext" data-direction="reverse" class="ui-btn-right jqm-home">Settings</a> 
  </div>

I then open dialogs above that app, and often times (I notice it particularly in Android browser), when I click the upper left close button on the dialog, the dialog-opening page appears but then the home page appears after that. When I comment out the home button, it works as expected. I suspect that it's interpreting the dialog close click as a click on the "home" button as well.

Let me know if you need a fuller example for replication.

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 29, 2011

Contributor

Have you tried testing this with our latest build (find here http://jquerymobile.com/blog/2011/04/16/latest/ )? It may be related to a bug we've fixed after beta (and we are currently working on a better fix). Thanks!

Contributor

scottjehl commented Jun 29, 2011

Have you tried testing this with our latest build (find here http://jquerymobile.com/blog/2011/04/16/latest/ )? It may be related to a bug we've fixed after beta (and we are currently working on a better fix). Thanks!

@pamelafox

This comment has been minimized.

Show comment
Hide comment
@pamelafox

pamelafox Jun 29, 2011

Just tried with the "latest" minified JS and CSS. It doesn't happen every single time, but still happens most of the time.

pamelafox commented Jun 29, 2011

Just tried with the "latest" minified JS and CSS. It doesn't happen every single time, but still happens most of the time.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Jun 29, 2011

Contributor

We're still tinkering with these double click events. As you said, it's more of a problem in Android, especially 2.1. Surprised the latest didn't make this work quite a bit better.

Contributor

toddparker commented Jun 29, 2011

We're still tinkering with these double click events. As you said, it's more of a problem in Android, especially 2.1. Surprised the latest didn't make this work quite a bit better.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Jun 30, 2011

Contributor

Ok, we just made a bigger change that should put events back to where they were pre-beta 1. Can you try the latest again:

<link href="http://code.jquery.com/mobile/latest/jquery.mobile.min.css" rel="stylesheet" type="text/css" />
<script src="http://code.jquery.com/jquery-1.6.1.min.js"></script>
<script src="http://code.jquery.com/mobile/latest/jquery.mobile.min.js"></script>
Contributor

toddparker commented Jun 30, 2011

Ok, we just made a bigger change that should put events back to where they were pre-beta 1. Can you try the latest again:

<link href="http://code.jquery.com/mobile/latest/jquery.mobile.min.css" rel="stylesheet" type="text/css" />
<script src="http://code.jquery.com/jquery-1.6.1.min.js"></script>
<script src="http://code.jquery.com/mobile/latest/jquery.mobile.min.js"></script>
@pamelafox

This comment has been minimized.

Show comment
Hide comment
@pamelafox

pamelafox Jun 30, 2011

That seems to be working for me, thanks!

pamelafox commented Jun 30, 2011

That seems to be working for me, thanks!

@scottjehl scottjehl closed this Jun 30, 2011

@mtin79

This comment has been minimized.

Show comment
Hide comment
@mtin79

mtin79 Dec 7, 2011

i got the same issue and i am using jquerymobile final 1.0

mtin79 commented Dec 7, 2011

i got the same issue and i am using jquerymobile final 1.0

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 7, 2011

Contributor

@mtin79 - Guessing this is on Android?

Contributor

toddparker commented Dec 7, 2011

@mtin79 - Guessing this is on Android?

@mtin79

This comment has been minimized.

Show comment
Hide comment
@mtin79

mtin79 Dec 7, 2011

unfortunatelly i got this on the iphone.

mtin79 commented Dec 7, 2011

unfortunatelly i got this on the iphone.

@lovableCurmudgeon

This comment has been minimized.

Show comment
Hide comment
@lovableCurmudgeon

lovableCurmudgeon Dec 27, 2011

I have the same issue with the dialog box "close" button activating other buttons on the page. I've managed to move it off of most of them by adjusting the top margin to
.ui-dialog .ui-header{
margin: 30% auto 15px auto;
}
However, that's just a workaround. This happens on all devices, jqm 1.0.

lovableCurmudgeon commented Dec 27, 2011

I have the same issue with the dialog box "close" button activating other buttons on the page. I've managed to move it off of most of them by adjusting the top margin to
.ui-dialog .ui-header{
margin: 30% auto 15px auto;
}
However, that's just a workaround. This happens on all devices, jqm 1.0.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Jan 1, 2012

Contributor

@lovableCurmudgeon - are transitions off? I've never seen this type of issue on iOS.

Contributor

toddparker commented Jan 1, 2012

@lovableCurmudgeon - are transitions off? I've never seen this type of issue on iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment