New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degradeInputs in latest git version gone #2123

Closed
negue opened this Issue Jul 21, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@negue
Contributor

negue commented Jul 21, 2011

Is this now a new feature or just a bug?

I really would need the feature back .... :)

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jul 21, 2011

Contributor

Worked on it today. Almost done. Hang tight :)

Contributor

scottjehl commented Jul 21, 2011

Worked on it today. Almost done. Hang tight :)

@anho

This comment has been minimized.

Show comment
Hide comment
@anho

anho Jul 26, 2011

Need this one too.

anho commented Jul 26, 2011

Need this one too.

@scottjehl scottjehl closed this in 79d3aa6 Jul 26, 2011

@OwenBrotherwood

This comment has been minimized.

Show comment
Hide comment
@OwenBrotherwood

OwenBrotherwood Aug 12, 2011

By the way, the doc @ http://jquerymobile.com/test/docs/forms/plugin-eventsmethods.html indicates that the type="search" will be degraded to type="text": but the type get's degraded to type="true".
This is an old feature, not caused by the commit.

The code problem could be the:
search: true, // should be search: "text" ???
optType = o.degradeInputs[ type ] || "text"; // the value for search is "true"
if ( o.degradeInputs[ type ] ) { //

And one could save a micro micro sec by having the declaratiom of optType statement in the code segment:
if ( o.degradeInputs[ type ] ) {
optType=o.degradeInputs[type];

Degraded Form Input Types
jQuery Mobile degrades several HTML5 input types back to type=text, or type=number after adding enhanced controls. For example, inputs with a type of range are enhanced with a custom slider control, and their type is set to number to offer a usable form input alongside that slider. Inputs with a type of search are degraded back to type=text after we add our own themable search input styling.

OwenBrotherwood commented Aug 12, 2011

By the way, the doc @ http://jquerymobile.com/test/docs/forms/plugin-eventsmethods.html indicates that the type="search" will be degraded to type="text": but the type get's degraded to type="true".
This is an old feature, not caused by the commit.

The code problem could be the:
search: true, // should be search: "text" ???
optType = o.degradeInputs[ type ] || "text"; // the value for search is "true"
if ( o.degradeInputs[ type ] ) { //

And one could save a micro micro sec by having the declaratiom of optType statement in the code segment:
if ( o.degradeInputs[ type ] ) {
optType=o.degradeInputs[type];

Degraded Form Input Types
jQuery Mobile degrades several HTML5 input types back to type=text, or type=number after adding enhanced controls. For example, inputs with a type of range are enhanced with a custom slider control, and their type is set to number to offer a usable form input alongside that slider. Inputs with a type of search are degraded back to type=text after we add our own themable search input styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment