New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar wrapping on Blackberry OS 5 #2159

Closed
robberry opened this Issue Jul 28, 2011 · 16 comments

Comments

Projects
None yet
6 participants
@robberry

robberry commented Jul 28, 2011

The navbar wraps on Blackberry OS5 because of a vertical scroll bar on the right hand side. It also seems to be pushing some other elements out i.e. count bubble on list.

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 2, 2011

I temporarily fixed this issue by adding a little of code (before this one I have a filter for BlackBerry)

if(navigator.userAgent.match(/(5.0)/)){
$('ul.ui-grid-a > li.ui-block-a').width('49.9%');
}

communiq commented Aug 2, 2011

I temporarily fixed this issue by adding a little of code (before this one I have a filter for BlackBerry)

if(navigator.userAgent.match(/(5.0)/)){
$('ul.ui-grid-a > li.ui-block-a').width('49.9%');
}

@robberry

This comment has been minimized.

Show comment
Hide comment
@robberry

robberry Aug 3, 2011

The above doesn't seem to fix the issue I have, but I can see how it might.

Any other suggestions?

robberry commented Aug 3, 2011

The above doesn't seem to fix the issue I have, but I can see how it might.

Any other suggestions?

@robberry robberry closed this Aug 3, 2011

@robberry robberry reopened this Aug 3, 2011

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 3, 2011

yeah, but it works on simulator and BB 9000 bold

communiq commented Aug 3, 2011

yeah, but it works on simulator and BB 9000 bold

@reprotector

This comment has been minimized.

Show comment
Hide comment
@reprotector

reprotector Aug 3, 2011

Same issue here.

Tested in BB 9800, 8520 and 9650:
BB 9800 - Vodafone with OS 6.0 works
BB 8520 and 9650 with OS 5.0 does not.

reprotector commented Aug 3, 2011

Same issue here.

Tested in BB 9800, 8520 and 9650:
BB 9800 - Vodafone with OS 6.0 works
BB 8520 and 9650 with OS 5.0 does not.

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 3, 2011

$('div[data-role=page]').live('pageshow', function(event)
{
if(navigator.userAgent.match(/(5.0)/)){
$('ul.ui-grid-a > li.ui-block-a').width('49.9%');
}
});
Just put this one to head > script

communiq commented Aug 3, 2011

$('div[data-role=page]').live('pageshow', function(event)
{
if(navigator.userAgent.match(/(5.0)/)){
$('ul.ui-grid-a > li.ui-block-a').width('49.9%');
}
});
Just put this one to head > script

@reprotector

This comment has been minimized.

Show comment
Hide comment
@reprotector

reprotector Aug 3, 2011

The above code doesn't fix my issue. Please check my problem here: http://www.image-share.com/ipng-826-212.html

reprotector commented Aug 3, 2011

The above code doesn't fix my issue. Please check my problem here: http://www.image-share.com/ipng-826-212.html

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 3, 2011

So, you have 4 items in navbar. I have 2 items, so you should do the same but for "ul.ui-grid-c > li.ui-block-a" and set this block to 25%-0.1%=24.9% or something like that :)

communiq commented Aug 3, 2011

So, you have 4 items in navbar. I have 2 items, so you should do the same but for "ul.ui-grid-c > li.ui-block-a" and set this block to 25%-0.1%=24.9% or something like that :)

@reprotector

This comment has been minimized.

Show comment
Hide comment
@reprotector

reprotector Aug 3, 2011

@communiq, I love you.

I saw that you did it for 2 items but I forgot data-grid c :)

Thanks very much!

reprotector commented Aug 3, 2011

@communiq, I love you.

I saw that you did it for 2 items but I forgot data-grid c :)

Thanks very much!

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 3, 2011

You are welcome :)

communiq commented Aug 3, 2011

You are welcome :)

@communiq

This comment has been minimized.

Show comment
Hide comment
@communiq

communiq Aug 3, 2011

I have tested couple of minutes ago that in nightly builds - have the same bug :)

communiq commented Aug 3, 2011

I have tested couple of minutes ago that in nightly builds - have the same bug :)

@robberry

This comment has been minimized.

Show comment
Hide comment
@robberry

robberry Aug 3, 2011

This fixed it for me too. Well done! Now just to build it into the main codebase.

robberry commented Aug 3, 2011

This fixed it for me too. Well done! Now just to build it into the main codebase.

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Apr 29, 2012

Member

Hi everyone, is this still an issue with latest?

Member

agcolom commented Apr 29, 2012

Hi everyone, is this still an issue with latest?

@ghost ghost assigned jasondscott May 22, 2012

@jasondscott

This comment has been minimized.

Show comment
Hide comment
@jasondscott

jasondscott May 30, 2012

Contributor

Confirmed. It is still an issue on latest

Contributor

jasondscott commented May 30, 2012

Confirmed. It is still an issue on latest

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 1, 2012

Member

I reference two other issues here since we should look at them all when we work on a fix.
IE7 navbar buttons wrap: #2270
Navbar buttons leave gap at the right: #3341

Member

jaspermdegroot commented Jun 1, 2012

I reference two other issues here since we should look at them all when we work on a fix.
IE7 navbar buttons wrap: #2270
Navbar buttons leave gap at the right: #3341

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 12, 2012

Member

Hi all,

See PR #4514 which contains a link to a test page. Can you try this on your devices and let me know if the issue is fixed and no other issues occur on BB5? Thanks!

Member

jaspermdegroot commented Jun 12, 2012

Hi all,

See PR #4514 which contains a link to a test page. Can you try this on your devices and let me know if the issue is fixed and no other issues occur on BB5? Thanks!

jaspermdegroot added a commit that referenced this issue Jun 16, 2012

Fixes #2270 and #2159 - Adjusted grid blocks percentage width to prev…
…ent wrapping on older browsers and set it back for modern browsers. Minor adjustment for grid-a to fix BB5 issue.
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 16, 2012

Member

Fixed by merging commits from PR #4514

Member

jaspermdegroot commented Jun 16, 2012

Fixed by merging commits from PR #4514

jaspermdegroot added a commit that referenced this issue Jun 16, 2012

Fixes #2270 and #2159 - Adjusted grid blocks percentage width to prev…
…ent wrapping on older browsers and set it back for modern browsers. Minor adjustment for grid-a to fix BB5 issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment