Skip to content
This repository

Beta 2: ui-body-swatch class reapplied to content #2221

Closed
abdulqadir opened this Issue August 05, 2011 · 1 comment

2 participants

abdulqadir Scott Jehl
abdulqadir

The class for the page theme is added to the content div if no separate theme swatch for data-role="content" is specified.

This makes the background gradient look jarred if the page is short on content.
Please see http://jsfiddle.net/abdulqadir/cvzZD/

If we go back to the previous method of applying a theme to the content area only if one is explicitly specified, the effect is a lot smoother.

Modifying line 82 in jquery.mobile.page.sections.js from

$this.addClass( "ui-body-" + ( theme || pageTheme || o.contentTheme ) );

to

if (theme || o.contentTheme) {
    $this.addClass( "ui-body-" + ( theme || o.contentTheme ) );
}

would bring back the old functionality

Scott Jehl

Great point. This is one regression that occurred during decoupling that I'd been trying to track down. We'll get this in asap!

Scott Jehl scottjehl closed this issue from a commit August 05, 2011
Brought back the page content div theme inheritance from b1. Thanks t…
…o abdulqadir for the suggestion. Fixes #2221
28eebc2
Scott Jehl scottjehl closed this in 28eebc2 August 05, 2011
Jim Tilson brendansoftllc referenced this issue from a commit August 15, 2011
Commit has since been removed from the repository and is no longer available.
Timmy Willison timmywil referenced this issue from a commit August 05, 2011
Brought back the page content div theme inheritance from b1. Thanks t…
…o abdulqadir for the suggestion. Fixes #2221
ebbdbc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.