Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 2: ui-body-swatch class reapplied to content #2221

Closed
abdulqadir opened this issue Aug 5, 2011 · 1 comment
Closed

Beta 2: ui-body-swatch class reapplied to content #2221

abdulqadir opened this issue Aug 5, 2011 · 1 comment

Comments

@abdulqadir
Copy link

@abdulqadir abdulqadir commented Aug 5, 2011

The class for the page theme is added to the content div if no separate theme swatch for data-role="content" is specified.

This makes the background gradient look jarred if the page is short on content.
Please see http://jsfiddle.net/abdulqadir/cvzZD/

If we go back to the previous method of applying a theme to the content area only if one is explicitly specified, the effect is a lot smoother.

Modifying line 82 in jquery.mobile.page.sections.js from

$this.addClass( "ui-body-" + ( theme || pageTheme || o.contentTheme ) );

to

if (theme || o.contentTheme) {
    $this.addClass( "ui-body-" + ( theme || o.contentTheme ) );
}

would bring back the old functionality

@scottjehl
Copy link
Contributor

@scottjehl scottjehl commented Aug 5, 2011

Great point. This is one regression that occurred during decoupling that I'd been trying to track down. We'll get this in asap!

@scottjehl scottjehl closed this in 28eebc2 Aug 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.