Flip toggle switches don't animate when tapped. #2346

Closed
jblas opened this Issue Aug 26, 2011 · 2 comments

1 participant

@jblas

The flip toggle switches used to animate when you tapped/toggled them. It seems this checkin:

2dea6cd#js/jquery.mobile.forms.slider.js

broke this because it sets the value (via refresh) prior to the animation being set up.

I have a fix for this.

@jblas jblas was assigned Aug 26, 2011
@jblas

The fix for this is on the 'transitions' branch and can be found here:

31f61e5#js/jquery.mobile.forms.slider.js

It can land on the HEAD once the $.fn.transitionComplete() method lands from the 'transitions' branch.

@jblas

I landed the selector fix to enable animation on the HEAD:

a27f7d3

Also landed a related fix that removed the bogus animationComplete() call. This was not necessary since an animationend event will never be generated for a CSS3 transition, and was leading to us binding a new handler every time the switch was clicked.

7bf048a

@jblas jblas closed this Sep 1, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment