New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - middle clicking link does not open target in new tab #2438

Closed
sinewave42 opened this Issue Sep 14, 2011 · 6 comments

Comments

Projects
None yet
6 participants
@sinewave42

sinewave42 commented Sep 14, 2011

Your online documentaion is a nice demonstration of the library. But it's documentation, so I need to be able to open links in a new tab. Middle clicking on a link, which is my normal way of opening a new tab, opens the link target in the current tab. So does ctrl-clicking, and so does right-clicking to try to open a new tab through the context menu. (All with Firefox 6.0.2 on Windows). Middle-click and ctrl-click also open in the same tab in Chrome 13.0.782.220 (release) on Windows, but right-clicking brings up the context menu correctly. The only way I've found to open the links in a new tab in Firefox is to drag them onto the tab bar, which opens a new tab with the linked URL.

@gseguin gseguin closed this Sep 14, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 14, 2011

Contributor

I don't appreciate the tone of this message, it's completely unnecessary. On my Mac, I can right click and choose the "open in a new tab". I can also Command click to open in a new tab. Not sure what a middle mouse button is, but standard gestures and behaviors seem to work fine for me.

Closing, not an issue.

Contributor

toddparker commented Sep 14, 2011

I don't appreciate the tone of this message, it's completely unnecessary. On my Mac, I can right click and choose the "open in a new tab". I can also Command click to open in a new tab. Not sure what a middle mouse button is, but standard gestures and behaviors seem to work fine for me.

Closing, not an issue.

@sinewave42

This comment has been minimized.

Show comment
Hide comment
@sinewave42

sinewave42 Sep 14, 2011

Sorry for the tone of my initial message, you're right, it was completely unneccessary. I've edited it because of that, but also because both the alternative methods you suggest don't work for me either. It's not a major issue, but it is an issue for me.

sinewave42 commented Sep 14, 2011

Sorry for the tone of my initial message, you're right, it was completely unneccessary. I've edited it because of that, but also because both the alternative methods you suggest don't work for me either. It's not a major issue, but it is an issue for me.

@begmandev

This comment has been minimized.

Show comment
Hide comment
@begmandev

begmandev Sep 14, 2011

FWIW. This definitely seems to be a problem on Firefox. Right-clicking on a linked-element results in the normal click event being fired instead of allowing the context menu to be displayed. So, if you go to the JQM docs and right-click on any links, list items, etc. it navigates directly to the target location instead of allowing the context menu to be displayed.

begmandev commented Sep 14, 2011

FWIW. This definitely seems to be a problem on Firefox. Right-clicking on a linked-element results in the normal click event being fired instead of allowing the context menu to be displayed. So, if you go to the JQM docs and right-click on any links, list items, etc. it navigates directly to the target location instead of allowing the context menu to be displayed.

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 14, 2011

Contributor

@jblas

johnbender@afcd1c5

See any issues with the above? I'll also include a test and a small refactor to consolidate the early exit stuff from click handling in nav.

Contributor

johnbender commented Sep 14, 2011

@jblas

johnbender@afcd1c5

See any issues with the above? I'll also include a test and a small refactor to consolidate the early exit stuff from click handling in nav.

@johnbender johnbender reopened this Sep 14, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Sep 15, 2011

Contributor

@johnbender

I updated your patch with the following comment:

"This looks ok, but we're going to have to sync up the vclick stuff too. That is, we are marking links as active on vclick, and executing the actions on click ... they both need to check for event.which ... but, we also have to modify the vmouse events so that they generate a event.which property for touch events. Note that vmouse events that are the result of real mouse events already have 'which' properties on them."

Contributor

jblas commented Sep 15, 2011

@johnbender

I updated your patch with the following comment:

"This looks ok, but we're going to have to sync up the vclick stuff too. That is, we are marking links as active on vclick, and executing the actions on click ... they both need to check for event.which ... but, we also have to modify the vmouse events so that they generate a event.which property for touch events. Note that vmouse events that are the result of real mouse events already have 'which' properties on them."

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Sep 15, 2011

Contributor

416b666

Closed with that commit.

Contributor

johnbender commented Sep 15, 2011

416b666

Closed with that commit.

@johnbender johnbender closed this Sep 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment