New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jqmHasData #2455

Closed
gnarf opened this Issue Sep 15, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@gnarf
Member

gnarf commented Sep 15, 2011

I was testing some changes I've made in the 1.7 data code against mobile and in review of the jqmData functions I found that you were calling $.hasData( elem, key ) - $.hasData only takes one argument - it just tells you if there is even a data cache for the object.

This makes me wonder if jqmHasData is even a necessary function - if it is, I could see it as a function that checks $.hasData then loops $(elem).data() for any jqm namespaced .data() keys perhaps.

@gnarf

This comment has been minimized.

Show comment
Hide comment
@gnarf

gnarf Sep 15, 2011

Member

After conversation in IRC today - I'm leaning towards the fact that you don't even need this function in your API...

Member

gnarf commented Sep 15, 2011

After conversation in IRC today - I'm leaning towards the fact that you don't even need this function in your API...

gseguin added a commit that referenced this issue Sep 16, 2011

Fix for issue #2455
Removed .jqmHasData()

gseguin added a commit that referenced this issue Sep 16, 2011

Fix for issue #2455
Updated doc
@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Sep 16, 2011

Member

I removed .jqmHasData(). we will re-add it when .jqmData() has the right behavior which is to return a hash with only the data in jQM's namespace

Member

gseguin commented Sep 16, 2011

I removed .jqmHasData(). we will re-add it when .jqmData() has the right behavior which is to return a hash with only the data in jQM's namespace

@gseguin gseguin closed this Sep 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment