jqmHasData #2455

Closed
gnarf opened this Issue Sep 15, 2011 · 2 comments

Projects

None yet

2 participants

@gnarf
Member
gnarf commented Sep 15, 2011

I was testing some changes I've made in the 1.7 data code against mobile and in review of the jqmData functions I found that you were calling $.hasData( elem, key ) - $.hasData only takes one argument - it just tells you if there is even a data cache for the object.

This makes me wonder if jqmHasData is even a necessary function - if it is, I could see it as a function that checks $.hasData then loops $(elem).data() for any jqm namespaced .data() keys perhaps.

@gnarf
Member
gnarf commented Sep 15, 2011

After conversation in IRC today - I'm leaning towards the fact that you don't even need this function in your API...

@gseguin gseguin added a commit that referenced this issue Sep 16, 2011
@gseguin gseguin Fix for issue #2455
Removed .jqmHasData()
15667ee
@gseguin gseguin added a commit that referenced this issue Sep 16, 2011
@gseguin gseguin Fix for issue #2455
Updated doc
dbab6c0
@gseguin
Member
gseguin commented Sep 16, 2011

I removed .jqmHasData(). we will re-add it when .jqmData() has the right behavior which is to return a hash with only the data in jQM's namespace

@gseguin gseguin closed this Sep 16, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment